🛡️ Sentinel: Fix exception detail leakage in login_required decorator - #19
Conversation
Prevent internal exception details from being returned to unauthenticated clients in auth/utils.py's login_required decorator. Log authentication failures internally and return generic error responses. Add unit test coverage for auth utilities. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🛡️ Sentinel: Fix error detail leakage in auth decorator
🚨 Severity: MEDIUM
💡 Vulnerability: Exposing raw exception strings (
str(e)) in API response JSON when authentication fails inauth/utils.py.🎯 Impact: Attackers or unauthorized users could inspect exception details (e.g., DB errors, connection strings, stack traces) to map internal architecture or system state.
🔧 Fix: Removed
details: str(e)from the response payload, logged warning server-side, and added unit tests intests/test_auth_utils.py.✅ Verification: Ran
python3 -m pytest(all tests pass) andPYTHONPATH=src python3 -m pylint src/automation src/handoff auth tests --fail-under=7.0.PR created automatically by Jules for task 8578887029011382795 started by @Pmaster-dev