Add coverage for post-tag-version-bump (pgxntool issue #20) - #74
Draft
jnasbyupgrade wants to merge 1 commit into
Draft
Add coverage for post-tag-version-bump (pgxntool issue #20)#74jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
…sions#20) Add tests/updates for pgxntool commit d550cae (adds make post-tag-version-bump + bump-default-version.sh to freeze default_version after a release): - New PGXNTOOL_ENABLE_POST_TAG_VERSION_BUMP / PGXNTOOL_POST_TAG_VERSION variables, following the existing PGXNTOOL_ENABLE_*/PGXNTOOL_* pattern - bump-default-version.sh rewrites a control file's default_version in place, preserving trailing comments New test/standard/tag-version-bump.bats: - Standalone script-logic tests for bump-default-version.sh (quoted styles, trailing comments, multiple control files, error cases) -- no make, no foundation, no PostgreSQL - make -n dry-run coverage of post-tag-version-bump's enable/disable/value override wiring - Stub-based coverage (_POST_TAG_VERSION_BUMP_SCRIPT) proving the script is genuinely invoked or skipped, without depending on its real behavior - One real end-to-end test proving default_version actually gets bumped and the placeholder's SQL file gets generated on the next build Also adds pgxntool/bump-default-version.sh to the exact distribution manifest (test/lib/dist-expected-files.txt) -- pgxntool's own root scripts are included verbatim in a project's distribution, so a new one changes what make dist is expected to produce. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds BATS coverage for Postgres-Extensions/pgxntool#95, which adds
make post-tag-version-bump(bumpsdefault_versionto a placeholder alias after a release, via newbump-default-version.sh) plusPGXNTOOL_ENABLE_POST_TAG_VERSION_BUMP/PGXNTOOL_POST_TAG_VERSION.New
test/standard/tag-version-bump.bats:bump-default-version.sh(quoted styles, trailing comments, multiple control files, error cases) -- no make, no foundation, no PostgreSQLmake -ndry-run coverage ofpost-tag-version-bump's enable/disable/value override wiring_POST_TAG_VERSION_BUMP_SCRIPT) proving the script is genuinely invoked or skipped, without depending on its real behaviordefault_versionactually gets bumped and the placeholder's SQL file gets generated on the next buildAlso adds
pgxntool/bump-default-version.shto the exact distribution manifest (test/lib/dist-expected-files.txt).Test plan
test/standard/tag-version-bump.bats(8/8 passed)test-allsuite (256/256 passed, 0 skipped)