Skip to content

Add coverage for post-tag-version-bump (pgxntool issue #20) - #74

Draft
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:issue-20-stable-version-bump
Draft

Add coverage for post-tag-version-bump (pgxntool issue #20)#74
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:issue-20-stable-version-bump

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

Summary

Adds BATS coverage for Postgres-Extensions/pgxntool#95, which adds make post-tag-version-bump (bumps default_version to a placeholder alias after a release, via new bump-default-version.sh) plus PGXNTOOL_ENABLE_POST_TAG_VERSION_BUMP/PGXNTOOL_POST_TAG_VERSION.

New test/standard/tag-version-bump.bats:

  • Standalone script-logic tests for bump-default-version.sh (quoted styles, trailing comments, multiple control files, error cases) -- no make, no foundation, no PostgreSQL
  • make -n dry-run coverage of post-tag-version-bump's enable/disable/value override wiring
  • Stub-based coverage (_POST_TAG_VERSION_BUMP_SCRIPT) proving the script is genuinely invoked or skipped, without depending on its real behavior
  • One real end-to-end test proving default_version actually gets bumped and the placeholder's SQL file gets generated on the next build

Also adds pgxntool/bump-default-version.sh to the exact distribution manifest (test/lib/dist-expected-files.txt).

Test plan

  • test/standard/tag-version-bump.bats (8/8 passed)
  • Full test-all suite (256/256 passed, 0 skipped)

…sions#20)

Add tests/updates for pgxntool commit d550cae (adds make
post-tag-version-bump + bump-default-version.sh to freeze default_version
after a release):
- New PGXNTOOL_ENABLE_POST_TAG_VERSION_BUMP / PGXNTOOL_POST_TAG_VERSION
  variables, following the existing PGXNTOOL_ENABLE_*/PGXNTOOL_* pattern
- bump-default-version.sh rewrites a control file's default_version in
  place, preserving trailing comments

New test/standard/tag-version-bump.bats:
- Standalone script-logic tests for bump-default-version.sh (quoted
  styles, trailing comments, multiple control files, error cases) -- no
  make, no foundation, no PostgreSQL
- make -n dry-run coverage of post-tag-version-bump's enable/disable/value
  override wiring
- Stub-based coverage (_POST_TAG_VERSION_BUMP_SCRIPT) proving the script
  is genuinely invoked or skipped, without depending on its real behavior
- One real end-to-end test proving default_version actually gets bumped
  and the placeholder's SQL file gets generated on the next build

Also adds pgxntool/bump-default-version.sh to the exact distribution
manifest (test/lib/dist-expected-files.txt) -- pgxntool's own root scripts
are included verbatim in a project's distribution, so a new one changes
what make dist is expected to produce.

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7e639d65-a688-4332-a580-b6c18a45bd24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant