chore: drop recourse and identity packages - #1
Merged
Conversation
Narrows the repository to the escrow core ahead of the Fhenix audit. Removed: - packages/recourse — pools, factory, policy registry, coverage manager, strategy router and their confidential variants - packages/identity — ERC-8004 agent identity/validation/reputation registries - 13 recourse-only files from packages/shared (RecoursePoolLib, PoolRiskLib, CoverageLib, CoverageInviteLib, PolicyRegistryLib, PoolFactoryLib, IUnderwriterPolicy, IConfidentialUnderwriterPolicy, pool/coverage/policy event interfaces, TestnetPausableBase) - SDK recourse surface: recourse/recourse-plain modules, pool and coverage instances, builder .recourse(), RecourseEventName and its listeners, CoverageNotActiveError, recourse addresses and ABIs - e2e recourse flow and its deploy/wiring steps Escrow ABI and storage layout are unchanged: setCoverageManager(), setUnderwriterFee() and coverageManager() stay, so an external coverage manager can still be wired in by address. Verified: forge test (200 escrow tests), sdk vitest (67), offchain ci (133 operator + coordinator), e2e run.sh (10), prettier --check, solhint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrows the repository to the escrow core ahead of the Fhenix audit.
packages/is nowescrow,offchain,sdk,shared.Removed
packages/recourse— pools, factory, policy registry, coverage manager, strategy router and their confidential variants.packages/identity— ERC-8004 agent identity / validation / reputation registries. Nothing else in the repository referenced them.packages/shared:RecoursePoolLib,PoolRiskLib,CoverageLib,CoverageInviteLib,PolicyRegistryLib,PoolFactoryLib,IUnderwriterPolicy,IConfidentialUnderwriterPolicy, the pool/coverage/policy event interfaces, and the unusedTestnetPausableBase.sdk.recourse/sdk.recoursePlain, pool and coverage instances (plain + confidential), the builder's.recourse()step,RecourseEventNameand its listeners,CoverageNotActiveError, recourse addresses and ABIs.e2e/flows/recourse.test.tsand the recourse deploy/wiring steps ine2e/run.sh.aderyn.toml,scripts/run-slither.sh, CODEOWNERS, PR template, README, SECURITY, CONTRIBUTING, LICENSE, NOTICE and the implementation-status doc.RELEASES.mdhistory is untouched; the change is recorded under a newUnreleasedheading.Deliberately kept — escrow ABI and storage layout are unchanged
EscrowandConfidentialEscrowstill exposesetCoverageManager(),setUnderwriterFee()andcoverageManager(). An external coverage manager can still be wired in by address, and no redeploy is forced by this PR. Two escrow tests covering that seam were renamed fromtest_recourse_*totest_underwriterFee_*.Type of Change
Packages Affected
@reineira-os/shared@reineira-os/escrow(tests renamed only — no contract changes)@reineira-os/sdkTesting
pnpm ci)forge buildforsharedandescrow)e2e/run.shgreen against anvil — 10 tests, after removing the recourse deploy stepspnpm format:checkandsolhint 'packages/*/contracts/**/*.sol'cleanSecurity Considerations
No change to access control, FHE paths, or fund handling.
setCoverageManager/setUnderwriterFeeremain owner- and coverage-manager-gated exactly as before. Worth flagging for the audit: withrecoursegone,setCoverageManageris a privileged setter whose counterparty no longer ships in this repository — expect it to be raised as an informational finding.