-
Notifications
You must be signed in to change notification settings - Fork 99
docs: clarify AWS Marketplace version #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Creativeklvn
wants to merge
1
commit into
Project-HAMi:master
Choose a base branch
from
Creativeklvn:aws-installation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ title: HAMi on AWS | |
| translated: true | ||
| --- | ||
|
|
||
| HAMi is now available on the AWS Marketplace, and you can quickly install it via Helm or AWS add-on. | ||
| HAMi is now available on the AWS Marketplace and can be installed via Helm or the AWS add-on. | ||
|
|
||
| ## Prerequisites | ||
|
|
||
|
|
@@ -14,6 +14,8 @@ Before installation, please ensure you have: | |
|
|
||
| ## Install with Helm | ||
|
|
||
| The installation below uses version `2.6.1-community`. To install a newer version, replace `2.6.1-community` in the Helm command with the latest version available on the [AWS Marketplace listing](https://aws.amazon.com/marketplace/pp/prodview-x237accxbpuwa). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-blocking: Could we add this to the Chinese page as well, either in this PR or a follow-up PR? Suggested translation: Here’s another small suggestion: would the version information be easier to notice if you wrapped it in a
|
||
|
|
||
| You can use the following commands to pull HAMi’s Helm chart and install it: | ||
|
|
||
| ```shell | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this page has translated: true and a zh mirror under i18n/zh, which this pr does not touch. should the version note go there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t understand Chinese, so I wouldn’t be able to update the
zhtranslation accurately. Would it be better to leave the Chinese mirror unchanged and have the translation updated separately?