docs(v2.9): correct GPU scoring formulas - #842
Conversation
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blackdragoon26 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe v2.9.0 GPU scheduling documentation updates Binpack and Spread scoring formulas to include virtual device slots, compute cores, and memory usage. The worked examples now use scores of 7.75 and 18.75. ChangesGPU Scheduling Documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This documentation-only update corrects GPU scoring formulas and examples consistently in English and Chinese, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/lgtm exactly the follow up i asked for on #759: scoped to the v2.9.0 english and chinese snapshots only, and the 7.75 and 18.75 figures match the three term formula in gpu_policy.go. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Corrects the GPU scoring formulas in the frozen v2.9.0 documentation.
The existing formulas omit the virtual-device slot utilization term, although this term was already part of
ComputeScorebefore the configurable scoring weights were introduced.This update:
6.75and17.75to7.75and18.75This PR does not backport the new
hami.io/device-scoring-weightsannotation, which belongs to the upcoming release documentation.Which issue(s) this PR fixes:
Follow-up to #759.
Checklist:
npm run lintandnpm run format:checkpassnpm run buildsucceeds for bothenandzhgit commit -s)AI Disclosure:
This PR is assisted with AI Assistance for formatting purpose check and am responsible for all the content pushed in this PR.
Summary by CodeRabbit