Skip to content

fix(tutorials): point local image override at scheduler.extender.image - #847

Open
togettoyou wants to merge 1 commit into
Project-HAMi:masterfrom
togettoyou:fix/tutorials-scheduler-extender-image-key
Open

fix(tutorials): point local image override at scheduler.extender.image#847
togettoyou wants to merge 1 commit into
Project-HAMi:masterfrom
togettoyou:fix/tutorials-scheduler-extender-image-key

Conversation

@togettoyou

@togettoyou togettoyou commented Sep 8, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Two labs pass --set scheduler.image.repository/tag, but the chart has no scheduler.image — it's scheduler.extender.image.

Checklist:

  • npm run lint and npm run format:check pass
  • npm run build succeeds for both en and zh
  • Chinese translation updated if English docs changed (or noted why not)
  • Commits are signed off (git commit -s)

Summary by CodeRabbit

  • Documentation
    • Updated HAMi Helm installation tutorials to use the scheduler extender image repository and tag settings.
    • Applied the corrected configuration consistently across English and Chinese guides for NVML mock and topology-aware scheduling labs.

@hami-robot hami-robot Bot added the kind/cleanup Refactoring, config, or tidy-up with no behavior change label Sep 8, 2026
@netlify

netlify Bot commented Sep 8, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 2b7ee2d
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a9fc523f88a5000076185c0
😎 Deploy Preview https://deploy-preview-847--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot

hami-robot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: togettoyou
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d266990a-87b4-4907-93a3-0d4ddcbe7c2a

📥 Commits

Reviewing files that changed from the base of the PR and between 499ddfa and 2b7ee2d.

📒 Files selected for processing (4)
  • i18n/zh/docusaurus-plugin-content-docs-tutorials/current/labs/nvml-mock.md
  • i18n/zh/docusaurus-plugin-content-docs-tutorials/current/labs/topology-aware-scheduling.md
  • tutorials/labs/nvml-mock.md
  • tutorials/labs/topology-aware-scheduling.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The tutorial Helm installation commands now configure local images through scheduler.extender.image.repository and scheduler.extender.image.tag in both English and Chinese documentation.

Changes

Helm image documentation

Layer / File(s) Summary
Update local image overrides
i18n/zh/docusaurus-plugin-content-docs-tutorials/current/labs/*.md, tutorials/labs/*.md
The NVML mock and topology-aware scheduling commands replace scheduler.image.* values with scheduler.extender.image.* values.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2b7ee

The tutorials now consistently configure the local scheduler extender image using the corrected Helm values. No merge-blocking risk remains.

Suggested reviewers: rootsongjc

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating tutorial commands to use the scheduler.extender.image override path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs area/i18n kind/cleanup Refactoring, config, or tidy-up with no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant