Skip to content

docs(i18n): update Chinese online installation guide - #856

Merged
mesutoezdil merged 1 commit into
Project-HAMi:masterfrom
togettoyou:docs/update-online-installation-zh
Sep 14, 2026
Merged

mesutoezdil merged 1 commit into
Project-HAMi:masterfrom
togettoyou:docs/update-online-installation-zh

Conversation

@togettoyou

@togettoyou togettoyou commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the Chinese translation to match the changes introduced in #815.

Checklist:

  • npm run lint and npm run format:check pass
  • npm run build succeeds for both en and zh
  • Chinese translation updated if English docs changed (or noted why not)
  • Commits are signed off (git commit -s)

Summary by CodeRabbit

  • Documentation
    • Updated the Chinese Helm online installation guide with clearer Kubernetes version-checking instructions.
    • Clarified that the scheduler image tag must match the Kubernetes server version.
    • Added a verification requirement that all containers show as ready in the READY column.

Signed-off-by: Junhao Zou <zoujh99@qq.com>
@hami-robot hami-robot Bot added the kind/cleanup Refactoring, config, or tidy-up with no behavior change label Sep 12, 2026
@netlify

netlify Bot commented Sep 12, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit 57dfed8
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6aa4eaeadbcb3e000825e50b
😎 Deploy Preview https://deploy-preview-856--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot

hami-robot Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: togettoyou
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: edb47acb-cb95-4fb1-94b1-9b8e3d92684b

📥 Commits

Reviewing files that changed from the base of the PR and between e98df81 and 57dfed8.

📒 Files selected for processing (1)
  • i18n/zh/docusaurus-plugin-content-docs/current/installation/online-installation.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

更新中文在线安装文档。文档新增 Kubernetes Server 版本检查说明,并要求验证时确认 hami-device-pluginhami-scheduler 的所有容器均已就绪。

Changes

在线安装文档

Layer / File(s) Summary
安装检查与验证说明
i18n/zh/docusaurus-plugin-content-docs/current/installation/online-installation.md
将 Kubernetes 版本章节改为检查 Kubernetes Server 版本,并将安装成功条件扩展为两个 Pod 均为 RunningREADY 列中的所有容器均已就绪。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 57dfe

This documentation-only change introduces no known merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the Chinese online installation guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@togettoyou

Copy link
Copy Markdown
Contributor Author

/cc @rootsongjc

@hami-robot
hami-robot Bot requested a review from rootsongjc September 12, 2026 06:03
@mesutoezdil

mesutoezdil commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

heads up, #712 already rewrites this same section (drops the kubernetes version step, new headings) in both en and zh. might get overwritten once that merges, worth rebasing after?

@togettoyou

Copy link
Copy Markdown
Contributor Author

@mesutoezdil Thanks for the heads-up. Yes, let's wait and see—it's even possible that this PR of mine won't be needed after all.

@mesutoezdil
mesutoezdil merged commit 8461ca4 into Project-HAMi:master Sep 14, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/i18n kind/cleanup Refactoring, config, or tidy-up with no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants