[Artifact 1456~1462] アイスブランドアーツの作成 - #2044
Open
ogachu0331 wants to merge 38 commits into
Open
ogachu0331 wants to merge 38 commits into
ogachu0331 wants to merge 38 commits into
Conversation
ogachu0331
marked this pull request as draft
June 4, 2026 16:33
ogachu0331
marked this pull request as ready for review
June 4, 2026 16:55
Lapis-LJA
requested changes
Jun 5, 2026
Lapis-LJA
left a comment
Lapis-LJA
left a comment
Contributor
There was a problem hiding this comment.
各武器用のobjectが用意されてるけど、内部処理は全く同じっぽいから1つに纏めるべきと感じた。
神器側で召喚時にCustomModelDataを設定してやればいい気がする
ogachu0331
changed the title
Contributor
Author
object#1161の処理にまとめました！ファイルの名前も変えました |
Contributor
Author
|
全ての修正と仕様変更終わりましたので再レビューお願いします |
ogachu0331
marked this pull request as draft
June 10, 2026 02:03
ogachu0331
marked this pull request as ready for review
June 10, 2026 02:04
ogachu0331
marked this pull request as draft
June 10, 2026 06:39
…TSB/Asset into dev/ogachu_aritifact1456
ogachu0331
marked this pull request as ready for review
June 10, 2026 09:45
ogachu0331
changed the title
Lapis-LJA
requested changes
Sep 3, 2026
| # 神器の名前 (TextComponentString) | ||
| data modify storage asset:artifact Name set value '{"text":"アイスブランドアーツ","color":"#7DFFF2","bold":true}' | ||
| # 神器の説明文 (TextComponentString[]) | ||
| data modify storage asset:artifact Lore set value ['{"text":"周囲に複数の氷製の神器を生成する","color":"white"}','{"text":"生成した神器は誰でも右クリックで回収可能","color":"white"}','{"text":"生成した神器は生成してから時間が経つほど威力が減衰する","color":"white"}'] |
Contributor
There was a problem hiding this comment.
周囲に複数の氷製の神器を生成する
生成した神器は誰でも右クリックで回収できる
生成してから時間が経つほど威力が減衰する
がいいんじゃないでしょうか
| function asset:artifact/common/check_condition/mainhand | ||
| # 他にアイテム等確認する場合はここに書く | ||
| # 戦闘外に使うべからず | ||
| execute unless predicate lib:in_battle run tellraw @s[tag=CanUsed] {"text":"戦闘中のみ使用可能です。","color":"red"} |
Contributor
There was a problem hiding this comment.
function lib:message/artifact/condition_not_met
でいいかも？
Contributor
Author
There was a problem hiding this comment.
ライブラリーなんでもあってすごいな...
修正しました
…TSB/Asset into dev/ogachu_aritifact1456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
テクスチャはまだなのと、威力とmp、cdは塩梅があまりわかってないのでなんとなくです。