fix(setup): executor install ref pointed at a non-existent branch - #488
Open
ProtocolWarden wants to merge 1 commit into
Open
fix(setup): executor install ref pointed at a non-existent branch#488ProtocolWarden wants to merge 1 commit into
ProtocolWarden wants to merge 1 commit into
Conversation
ensure_executor_installed defaulted to `ref = install_ref or "dev"`, but TeamExecutor has no `dev` branch. `git ls-remote` returns nothing for it, so `uv tool install git+...TeamExecutor.git@dev` failed on ref resolution and the operator saw only the generic "[executor] ERROR: installation failed" with no indication that the ref was the cause. Default to `main`. This is the OC-side half of a two-repo defect. The other half: TeamExecutor declared no [project.scripts], so even a successful install produced no `team-executor` binary and both check_command_installed and verify_executor would still fail. Fixed upstream by shipping the console script; the two changes are only useful together. Verified against OC's own consumers with a real install: check_command_installed -> True, verify_executor -> passes, and dependency_check's probe normalizes "team-executor 0.1.0" -> "0.1.0" with executor_installed True. Also correct docs/operator/setup.md. Its install/verify steps were accurate all along — they described a path the code could not satisfy until now. The real doc defect was elsewhere in that section: it implied the `team-executor` CLI is how OC executes tasks. It is not. Execution runs through the library API in-process via the editable sibling install; the CLI is only the verification surface. 13 setup CLI tests green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ProtocolWarden
force-pushed
the
fix/executor-install-ref
branch
from
August 4, 2026 20:57
a96aa01 to
2c4e11a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ensure_executor_installeddefaulted to:TeamExecutor has no
devbranch.git ls-remote --heads … TeamExecutor.git devreturns nothing, souv tool install git+https://github.com/ProtocolWarden/TeamExecutor.git@devfailed on ref resolution. The operator saw only the generic[executor] ERROR: installation failed, with no indication that the ref was the cause.Default is now
main(resolves to45f54ab3).Two-repo defect
This is the OC-side half. The other half: TeamExecutor declared no
[project.scripts], so even a successful install produced noteam-executorbinary —check_command_installed(ashutil.which) would still fail, andverify_executor'steam-executor --helpwould raiseexecutor not functioning.Fixed upstream in ProtocolWarden/TeamExecutor#19. The two changes are only useful together — merge that one first, or this still cannot complete an install.
On the documentation
Worth stating plainly, because this was initially mis-diagnosed as a stale doc line.
docs/operator/setup.md's install/verify steps were accurate all along. They faithfully described a code path that could not succeed. With both halves landed, the documented flow — "checks whetherteam-executoris onPATH", "verifies the install withteam-executor --help" — is true for the first time. No correction was needed there.The one real doc defect was a different line in that section: it implied the
team-executorCLI is how OC executes tasks. It is not. Execution runs through the library API in-process via the editable sibling install performed byensure_executor_backends; the CLI is only the verification surface. This PR says so explicitly.Verification
Against OC's own consumers with a real install:
13 setup CLI tests green. Custodian pre-push gate clean.
Note
The library path (
ensure_executor_backendseditable sibling install) was never affected by any of this — it is what actually runs tasks, which is why the breakage stayed invisible.🤖 Generated with Claude Code