Add Fastlane metadata - #1
licaon-kter wants to merge 1 commit into
Conversation
And while you set it, have it match the value released on Google Play. Google Play has versionCode 35 for 1.2.3, but from source it will be versionCode 8. |
|
@ProtonDriveTeam @dmihaljinec is there any specific reason this has now been open since nearly 2.5 years, yet Proton Drive is still not available on F-Droid? |
F-Droid availability always gets some low priority on our side. I hope that we will add support for it in the near future. Until then for non Google Play users there is not-so-nice approach to download apk from our web. |
|
@dmihaljinec Will you at least consider adding the apk and changelog to the releases in GitHub? Like you do for Proton Mail and Proton VPN. That way Obtainium plays along a little nicer. I guess it should be easily solved with a GitHub action or similar pipeline. |
Yes, I can create a release with attached apk. Regarding the changelog, I'll see what I can do. We have a changelog but it's not so helpful anymore as many things are behind a feature flag (FF) nowadays. Until FF is actually rolled out which could be in current or in some future release, user cannot actually use a feature so changelog might seem misleading. |
|
That sounds awesome! Small input from my side: I honestly dislike releases that don't include a changelog at all. Personally, I'd much rather see something like:
Even if a feature isn't immediately available to everyone, it's still useful to know what has changed under the hood and what is coming. A changelog with a few notes about feature flags is, in my opinion, much more helpful than having no changelog at all. Thanks :) |
Thanks a bunch! |
This is one step to get it included in F-Droid, 😉 https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12721
And start Tagging releases ;)
For easy maintenance maybe versionCode can be set as static instead of doing this?
android-drive/buildSrc/src/main/kotlin/DriveModule.kt
Line 226 in 8c04a52
I see versioName is already fine:
android-drive/buildSrc/src/main/kotlin/Config.kt
Line 25 in 8c04a52
If both are readable we can enable autoupdates, so F-Droid sees a new tag and builds the new version without manual intervention