Handle SQL parameter limit in GetTimeValues queries - #239
Merged
Conversation
Refactored time value retrieval to avoid exceeding SQL Server's 2,100 parameter limit. Added GetTimeValues_outer to split large parameter lists into chunks, query each chunk, and merge results. Renamed original GetTimeValues to GetTimeValues_inner and updated GetTimeValueList to use the new logic. This ensures support for large datasets without hitting SQL parameter constraints.
JohannesFinsveen
requested review from
PerIngeVaaje,
likp and
runejo
as code owners
August 17, 2026 12:36
runejo
reviewed
Aug 17, 2026
runejo
left a comment
runejo
left a comment
Member
There was a problem hiding this comment.
Looks good, but could you also fix the two SonarCloud issues?
Collaborator
Author
|
The two sonarCloud issues are now accepted. |
runejo
reviewed
Aug 19, 2026
| } | ||
|
|
||
| private DataSet GetTimeValues(string aMainTable, ICollection<string> valuesFromPxs) | ||
| private DataSet GetTimeValues_outer(string aMainTable, ICollection<string> valuesFromPxs) |
Member
There was a problem hiding this comment.
I would maybe keep the method name GetTimeValues instead of GetTimeValues_outer, otherwise it LGTM 👍
Contributor
|
@JohannesFinsveen I have tested it with one of our tables that was failing and now it works. Change back the name of the method see @runejo comment above and I am ready to approve the change. |
|
likp
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored time value retrieval to avoid exceeding SQL Server's 2,100 parameter limit. Added GetTimeValues_outer to split large parameter lists into chunks, query each chunk, and merge results. Renamed original GetTimeValues to GetTimeValues_inner and updated GetTimeValueList to use the new logic. This ensures support for large datasets without hitting SQL parameter constraints.
Both code and text from AI :-)
In ssb the max no. periods is less than 1400.