Conversation
Upgraded all projects to .NET 10.0 and updated test NuGet packages. Refactored test assertions to use Assert.HasCount and standardized exception assertions with Assert.ThrowsExactly. Improved async test cancellation handling via TestContext. Replaced [DataTestMethod] with [TestMethod] and modernized list initializations. Fixed string comparison issues and removed unnecessary System.Linq.Async package reference. Cleaned up namespaces and using directives for consistency.
CI, CD, and SonarScan workflows now use .NET 10.x instead of 8.x. CI matrix tests against .NET 9.x and 10.x. Px.Utils.csproj updated to target net10.0 and version 1.4.0.
Upgraded all projects to .NET 10.0 and updated test NuGet packages. Refactored test assertions to use Assert.HasCount and standardized exception assertions with Assert.ThrowsExactly. Improved async test cancellation handling via TestContext. Replaced [DataTestMethod] with [TestMethod] and modernized list initializations. Fixed string comparison issues and removed unnecessary System.Linq.Async package reference. Cleaned up namespaces and using directives for consistency.
CI, CD, and SonarScan workflows now use .NET 10.x instead of 8.x. CI matrix tests against .NET 9.x and 10.x. Px.Utils.csproj updated to target net10.0 and version 1.4.0.
Replaced incorrectly encoded Finnish characters with correct forms (e.g., "�" → "ä", "yhteens�" → "yhteensä") in test data for dimension names, units, and properties. This improves accuracy and readability in multilingual unit tests.
sakari-malkki
approved these changes
Mar 13, 2026
LauraRocks
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.