Skip to content

feat: Improve chart axis functionality - #1358

Merged
MikaelNordberg merged 16 commits into
mainfrom
feature/chart-axis
Aug 27, 2026
Merged

feat: Improve chart axis functionality#1358
MikaelNordberg merged 16 commits into
mainfrom
feature/chart-axis

Conversation

@MikaelNordberg

@MikaelNordberg MikaelNordberg commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Display measurement unit for the variable at the end of the axis.
Adaptive tick marks on y-axis.
Do not show chart when data contains contents with different units.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Branch Deployment to Cloudflare Pages

🚛 Preview URL: https://e8f1f836.pxweb2.pages.dev
🚧 Branch preview URL: https://feature-chart-axis.pxweb2.pages.dev
🚚 Alternative Preview URL: https://2fb275cd.pxweb2.pages.dev
👷 Alternative Branch preview URL: https://alternative-feature-chart-ax.pxweb2.pages.dev

@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@MikaelNordberg MikaelNordberg changed the title Feature/chart axis feat: Chart axis Aug 18, 2026
@mabl-bot

mabl-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Analysis

Regression: Check Header, Checkbox, Codelist, Tabell test fails on assertion

Root cause

  • Compared to immediate prior deployment: 0 recurring (same test also failed), 1 new.
  • Consecutive failing deployments (including this one): 1.
  • The test "Check Header, Checkbox, Codelist, Tabell" failed to assert that "21 of 21 selected" was displayed in the region selection, indicating a possible regression introduced in the feature/chart-axis branch regarding UI selection state.

Next steps

  • Investigate the changes made in the feature/chart-axis branch to see if they impact the UI selection state reporting for regions.
  • Verify if the region selection UI behavior has changed as part of the new feature and update the test assertion accordingly if the change is intentional.

Failed tests

View deployment results in mabl

@sonarqubecloud

Copy link
Copy Markdown

@SjurSutterudSagen SjurSutterudSagen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, great to see the clean up of the Presentation logic too!

@MikaelNordberg MikaelNordberg changed the title feat: Chart axis feat: Improve chart axis functionality Aug 27, 2026
@MikaelNordberg
MikaelNordberg merged commit d9ce7cb into main Aug 27, 2026
17 checks passed
@MikaelNordberg
MikaelNordberg deleted the feature/chart-axis branch August 27, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graph - Display unit/variable name at x-axis and y-axis

2 participants