docs: mark the 2 data.json auto-simulate guards as intentionally raw - #134
Merged
Conversation
Decision record for the file-path leg of the raw-guard migration (autolens_workspace#475, split from autolens_workspace#354): these guards check a file (dataset_0/data.json), and this workspace has no should_simulate namespace and never sets PYAUTO_SMALL_DATASETS (the recorded leg-3 rejection — adding an af.util.should_simulate plus a new env contract in PyAutoFit would buy zero functional gain). A one-line comment at each site records this so future sweeps don't re-flag them. Notebooks regenerated for the 2 touched scripts (carries the now-canonical setup_notebook activation from PyAutoHands 596967e). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EGua3k2WDPVrtvj4MTMUoT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decision record for the file-path leg of the raw-guard migration (PyAutoLabs/autolens_workspace#475, split from PyAutoLabs/autolens_workspace#354): the 2
data.jsonauto-simulate guards keep their raw file guard, each now marked with a one-line intentional-raw-guard comment so future migration sweeps don't re-flag them.Why: the guards check a file (
.../dataset_0/data.json), and this workspace has noshould_simulatenamespace and never setsPYAUTO_SMALL_DATASETS— the recorded leg-3 rejection: adding anaf.util.should_simulateplus a new env contract in PyAutoFit would buy zero functional gain.Scripts touched
scripts/features/graphical_models.pyscripts/features/shared_analysis_state.pyComment-only insertions (2 lines per site); no behaviour change.
Notebooks
Regenerated 1:1 for the 2 touched scripts via PyAutoHands (carries the now-canonical
setup_notebookactivation from PyAutoHands596967e; the repo-wide sweep of the other notebooks is left to the next wholesale regeneration). Navigator catalogue unchanged.Validation
py_compile2/2smoke_tests.txt; branch CI exercises the runtime stack.Companion PR: PyAutoLabs/autolens_workspace#477 (the 7
positions.jsonguards). No library dependency — no pending-release gate needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01EGua3k2WDPVrtvj4MTMUoT
Generated by Claude Code