docs: describe the MGE sigma floor as the pixel scale, not 0.01" - #10
Merged
Conversation
Phase 2 of the sweep started in autolens_workspace#467. Both pages claimed the MGE sigma ladder spans 0.01" to the mask radius. The helper actually spanned 1e-4 (PyAutoGalaxy#549 fixed that mismatch), and the workspace examples now floor the ladder at a tenth of the pixel scale, so the prose and the code samples were describing something that no longer exists. - `skills/ag_basis_profiles.md`: ladder prose + code sample updated; the point-model paragraph now names `sigma_min` and its 0.01" default. - `wiki/core/concepts/linear_light_profiles_and_mge.md`: same, plus a note on why the lower end is anchored to the pixel scale. Provenance: the wiki page gains `autogalaxy/analysis/model_util.py` as a cited path (it is where `sigma_min` lives, and the page now describes it), re-pins PyAutoGalaxy at 13d3023c (contains #549) and autogalaxy_workspace at 1f821ba (this sweep's phase-2 commit), and is re-stamped via --write-provenance. `audit_skill_apis.py` exits 0 with 0 missing/broken symbols. Not touched: `skills/ag_multi_dataset.md`, whose 1e-4 is an intensity LogUniformPrior rather than a sigma floor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
wiki-currency failure is pre-existing release drift, not this PRThe only failing sub-check is Evidence it is not caused by this PR:
Any PR opened against this repo today will hit the same failure until the baseline is re-pinned to I have deliberately not re-pinned it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the sweep started in autolens_workspace#467 (merged). Paired with autogalaxy_workspace#203.
Why
Both pages told users the MGE sigma ladder spans
0.01"to the mask radius. That was never what the code did —mge_model_fromhardcodednp.linspace(-4, ...), a 2-dex discrepancy that PyAutoGalaxy#549 fixed by making the floor configurable. The workspace examples now floor the ladder at a tenth of the pixel scale, so the prose and the code samples were describing something that exists nowhere.Changed
skills/ag_basis_profiles.md— ladder prose and code sample updated; the point-model paragraph now namessigma_minand its0.01"default rather than stating a bare literal.wiki/core/concepts/linear_light_profiles_and_mge.md— same, plus a short note on why the lower end is anchored to the pixel scale (it stops the basis spending Gaussians on scales the data cannot resolve).Not changed
skills/ag_multi_dataset.mdmatched a1e-4grep, but that is an intensityLogUniformPriorbound, not a sigma floor. Left alone.Provenance
The wiki page is provenance-stamped, so this PR also:
autogalaxy/analysis/model_util.pyto its cited PyAutoGalaxy paths — that is wheresigma_minlives, and the page now describes it13d3023c(verified to contain #549) and autogalaxy_workspace at1f821ba(this sweep's phase-2 commit)last_updatedand re-stampscontent_sha256via--write-provenanceautoassistant/audit_skill_apis.pyexits 0 with 0 missing/broken symbols across 46 files and 220 unique symbols.Note the wiki-currency workflow's paired-PR support applies here:
autogalaxy_workspacehas a branch of this same name, so the cited-source checkout grades against the paired change rather than againstmain.Merge gate
pending-release—sigma_minexists only on PyAutoGalaxymainand in no released PyAutoGalaxy.🤖 Generated with Claude Code