Phase 4a: the nine core-loop ag_* skills - #3
Closed
Jammy2211 wants to merge 2 commits into
Closed
Conversation
ag_setup_environment, ag_prepare_imaging_data (owns the real-data gate), ag_simulate_dataset, ag_build_imaging_model, ag_configure_search, ag_run_search, ag_plot_fit, ag_load_results, ag_debug_fit_failure — each grounded on named autogalaxy_workspace scripts and validated by EXECUTING its generated script (test-mode fit completed; aggregator round-trip; identifier silent-resume proven with identical hashes on different data). Reconciliation: skills/README index, PENDING.md, skill_citation_map rows; execution evidence corrected stale claims in AGENTS.md/_style.md/ plotting.md/sandbox.md/3 concept pages (output_filename is NOT universal — the six-function wheel-verified split is now documented; from_json returns a plain list; PYAUTO_TEST_MODE=2 writes no fit products). Trimmed two main-only APIs that leaked in from the local source stack (subplot_fit_imaging_list; the jitted-simulation pytree helper). Validation vs released wheel 2026.7.29.2: --check-version clean; --scope all 35 files / 0 missing; lint/citations/provenance clean; link sweep 667/0 broken; pytest 66 passed / 2 skipped. Epic: PyAutoLabs/PyAutoBrain#188 (Phase 4a) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EVSbY4u1JLfqRMgXYtnN9v
…e cone) Same class as the index.md fix on Phase 3: wiki-currency sparse-clones autogalaxy_workspace at scripts/ only, and the workspace commits no per-dataset READMEs anyway (imaging data is auto-simulated). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EVSbY4u1JLfqRMgXYtnN9v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4a of PyAutoLabs/PyAutoBrain#188 — the core modelling loop. Based on the Phase 3 branch (#2); GitHub will retarget to
mainwhen #2 merges.The nine skills
setup_environment · prepare_imaging_data (owns the real-data gate) · simulate_dataset · build_imaging_model · configure_search · run_search · plot_fit · load_results · debug_fit_failure — every code block adapted from a named
autogalaxy_workspacescript, every dotted symbol import-verified, and every skill's generated script actually executed (test-modesearch.fitcompleted; aggregator loaded the result back; the identifier silent-resume trap proven live: two different datasets, sameunique_tag, identical hash).Execution evidence corrected the docs
output_filenameis not universal: only 6 functions accept it on the released wheel (subplot_fit_imagingraisesTypeError— AGENTS.md's own "Right" example was a failing call). Full naming-kwarg split now in AGENTS.md,_style.md,plotting.md,ag_plot_fit.ag.from_json("galaxies.json")returns a plainlist, notag.Galaxies— 4 pages corrected, re-wrap idiom documented.PYAUTO_TEST_MODE=2writes no fit products (level 1 does) — sandbox.md now says so.subplot_fit_imaging_list, the jitted-simulation pytree-registration helper.Validation (clean-venv wheel
autogalaxy==2026.7.29.2)--check-versionclean ·--scope all35 files / 209 symbols / 0 missing · lint / citations (906) / provenance (0 errors) clean · link sweep 667 links / 0 broken · 16/16 skill symlinks resolve · pytest 66 passed / 2 skipped.Upstream findings (report-only)
autogalaxy_workspace:scripts/imaging/data_preparation/examples/psf.pynames a nonexistent symbol in prose (real:ag.preprocess.kernel_with_odd_dimensions_from).autogalaxy_workspace:scripts/imaging/modeling.pyclaims N=11 (and N=21) where the measured count is N=9.subplot_galaxiesdocstring default disagrees with its signature ("subplot_galaxies"vs"galaxies").🤖 Generated with Claude Code
https://claude.ai/code/session_01EVSbY4u1JLfqRMgXYtnN9v