Solved point-source runtime profiling + cluster breakdown solved steps (#657 phase 3) - #96
Merged
Merged
Conversation
… steps (#657 phase 3)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of PyAutoLens#657: likelihood-runtime profiling for the solved (centre-free) point-source fit variants. Adds runtime siblings for
FitPositionsImagePairAllSolved(+RepeatSolvedsteady-state entry) andFitPositionsSourceSolvedunder theresults/runtime/<class>/<model>/convention, and extends both cluster likelihood-breakdown scripts with solved-fit per-step entries on the standard cluster model. Headline: the analytic β* step costs ~timing-noise-level overhead per likelihood call (image-plane net +3% across systems; source-plane +9–30% on sub-0.1s eager fit totals) while removing 2 free parameters per point source from the non-linear space.Scripts Changed
scripts/point_source/likelihood_runtime/image_plane_solved.py— NEW sibling: lower/compile/first-call/steady-state timings forFitPositionsImagePairAllSolved, plus aFitPositionsImagePairRepeatSolvedsteady-state entry; results atresults/runtime/point_source/image_plane_solved/scripts/point_source/likelihood_runtime/source_plane_solved.py— NEW sibling forFitPositionsSourceSolved; full pipeline JITs cleanly (xp bug fixed in phase 2 / PyAutoArray#414); results atresults/runtime/point_source/source_plane_solved/scripts/cluster/likelihood_breakdown/image_plane.py— addsFitPositionsImagePairRepeatSolvedper-system fit-total steps + solved-vs-plain delta summary ("solved" JSON block; original step totals preserved)scripts/cluster/likelihood_breakdown/source_plane.py— adds plainFitPositionsSourceandFitPositionsSourceSolvedper-system fit-total steps (apples-to-apples) + delta summaryscripts/misc/likelihood_runtime/README.md— two new table rowsCommitted results (v2026.7.23.1, quiet-machine sequential runs): runtime JSON+PNG for both solved siblings, refreshed cluster breakdown JSON+PNG (now with solved steps), and the cluster simulator summary regenerated by the current simulator (the previous local dataset predated
scaling_galaxies.csv).Upstream PR
PyAutoLabs/PyAutoLens#659 (merged 2026-07-27).
Test Plan
Generated by the PyAutoLabs agent workflow.