refactor: rename the multi profiling package to multi_dataset - #97
Merged
Conversation
Phase 2b of the rename tracked at autolens_workspace#408.
scripts/multi/ -> scripts/multi_dataset/
dataset/multi/ -> dataset/multi_dataset/ (own, gitignored)
results/runtime/multi/ -> results/runtime/multi_dataset/
Also re-points the five prose references into autolens_workspace, whose
`scripts/multi/...` paths began returning 404 when #414 merged.
Safe against sweep.py: it builds `scripts/<cls>/likelihood_runtime/
<model>.py` from its CELLS list, and no cell names `multi` — so nothing
in the sweep matrix resolved through the renamed directory. It also
fails loudly ("!!! missing script") rather than silently if a path is
wrong.
Drive-by fixes, both pre-existing and both of which the rename would
otherwise have carried forward still-broken:
- `autolens_workspace_test/scripts/jax_likelihood_functions/multi/
shared_preloads.py` (x2) named a `jax_likelihood_functions/` directory
that does not exist; the real path is
`scripts/multi_dataset/jax_likelihood/shared_preloads.py`.
- `likelihood_runtime/multi/shared_preloads.py` (x2) had its two path
components reversed relative to the real
`multi_dataset/likelihood_runtime/shared_preloads.py`.
Deliberately NOT renamed: `scripts/misc/simulators/multi.py`, its
`multi_summary_v*.json` output stem, and the `"type": "multi"` field it
writes. Those three form one coherent identifier for this repo's own
profiling result series — nothing reads the field, the filename is a
separate literal, and renaming part of the triple would either orphan
the historical series or leave it internally inconsistent.
Verified: package byte-compiles; the renamed results directory keeps its
recorded .stdout intact (moved, not rewritten).
Refs PyAutoLabs/autolens_workspace#408
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2b of the
multi→multi_datasetrename (PyAutoLabs/autolens_workspace#408).What changed
scripts/multi/scripts/multi_dataset/dataset/multi/(own, gitignored)dataset/multi_dataset/results/runtime/multi/results/runtime/multi_dataset/Plus the five prose references into
autolens_workspace, whosescripts/multi/...paths started returning 404 when autolens_workspace#414 merged.The recorded
.stdoutunderresults/runtime/was moved, not rewritten — its content is untouched.Safe against
sweep.pyscripts/misc/likelihood_runtime/sweep.pybuildsscripts/<cls>/likelihood_runtime/<model>.pyfrom itsCELLSlist. No cell namesmulti, so nothing in the sweep matrix resolved through the renamed directory. It also fails loudly (!!! missing script) rather than silently if a path is wrong, so a mistake here would surface immediately rather than quietly skipping a cell.Drive-by fixes
Both pre-existing, and both of which the rename would otherwise have carried forward still broken:
autolens_workspace_test/scripts/jax_likelihood_functions/multi/shared_preloads.py(×2) names ajax_likelihood_functions/directory that does not exist. Real path:scripts/multi_dataset/jax_likelihood/shared_preloads.py.likelihood_runtime/multi/shared_preloads.py(×2) has its two path components reversed relative to the realmulti_dataset/likelihood_runtime/shared_preloads.py.Deliberately NOT renamed
scripts/misc/simulators/multi.py, itsmulti_summary_v*.jsonoutput stem, and the"type": "multi"field it writes.Those three form one coherent identifier for this repo's own profiling result series. Nothing reads the
"type"field (verified — it is write-only descriptive metadata), the output filename is a separate literal rather than derived from it, and renaming part of the triple would either orphan the historical series (multi_summary_v2026.5.14.2.json) or leave it internally inconsistent. Same call as thehard_group_multi.mdbenchmark id in autolens_assistant.Verification
Post-move sweep returns zero live hits except that deliberate triple; the renamed package byte-compiles.
Refs PyAutoLabs/autolens_workspace#408