fix: catch styled remote-control steps and align vitest coverage provider - #302
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe pull request updates remote-control output assertions and refreshes the web bundle hash, pnpm fetch hash, and ChangesRemote-control test and metadata updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change updates test assertions and dependency/build metadata without identified user-facing or production risk, so it is ready to merge with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
commit: |
…verage-align # Conflicts: # apps/pythinker-code/dist-web/.web-bundle-manifest.json # flake.nix
Related Issue
Follow-up to #301 (release PR for @pymodel/pythinker-code@1.13.0). No linked issue — maintainer-authored hygiene fixes surfaced during the release loop.
Problem
Two defects left behind by the release commit ce945e1:
/^\s*3\.\s/magainst raw CLI output.formatRemoteControlOutputwraps step numbers inchalk.bold.hex(label()), so any real third step renders as<ESC>[1m<ESC>[38;5;Nm3.<ESC>...and the line-start anchor never matches — the assertion cannot catch the regression it exists for (and its previous form, a plainnot.toContain('3.'), false-failed on the1.13.0version banner).@vitest/coverage-v8pinned at 4.1.9. The installed coverage provider requires the same exact vitest version and vitest warns that mixed provider/test-runner versions are unsupported. Plain test runs do not exercise this path.What changed
apps/pythinker-code/test/cli/web/remote-control.test.ts: moved the third-step assertion below the existing ANSI/OSC stripping and retargeted it toplain, so a styled3.step is caught after escapes are removed. Verified by temporarily injecting a styled third step through the samelabel()path — the test fails as required; reverted afterwards.package.json+pnpm-lock.yaml: aligned@vitest/coverage-v8to 4.1.11; focused--coveragerun loads the v8 provider with no mixed-version warning.flake.nix: refreshed thepnpmDepsfixed-output hash for the lockfile change.dist-web/.web-bundle-manifest.json(rootpackage.jsonis a web build input).No changeset: nothing here changes published manifests or user-visible behavior. No doc update needed.
Checklist
/approve). N/A — internal follow-up PR.gen-changesetsskill, or this PR needs no changeset. Needs none.gen-docsskill, or this PR needs no doc update. Needs none.Summary by CodeRabbit
Tests
Chores