Update from code changes: LogicVerifier DiagnosticResult migration - #250
Update from code changes: LogicVerifier DiagnosticResult migration#250mintlify[bot] wants to merge 2 commits into
Conversation
|
Skipping PR review because a bot author is detected. If you want to trigger CodeAnt AI, comment |
QWED Security Verification Report3 files scanned | 0 blocked | 0 warnings | 3 info | 0 suppressed | 1 verified Informational Findings
Engines
Verified Files
Verified by QWED — deterministic security verification. No LLM used. |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
| print(result.is_verified) # True | ||
| print(result.developer_fields["deterministic_verdict"]) # "SAT" | ||
| print(result.developer_fields["model"]) # {"x": "6", "y": "9"} |
There was a problem hiding this comment.
Quickstart uses the wrong result contract
When users run either updated client.verify_logic() example, the code accesses is_verified and developer_fields even though the high-level client retains its SAT/UNSAT/UNKNOWN response shape, causing attribute errors before the logic quickstart can complete.
Greptile SummaryDocuments the low-level
Confidence Score: 3/5The PR should not merge until the quickstart is restored to the unchanged high-level client response contract. The updated quickstart accesses Files Needing Attention: getting-started/quickstart.mdx
|
| Filename | Overview |
|---|---|
| changelog.mdx | Adds v5.4.0 release notes and correctly scopes the breaking result-contract change to direct LogicVerifier callers. |
| engines/logic.mdx | Adds comprehensive DiagnosticResult migration documentation and confirms that the high-level client response remains unchanged. |
| getting-started/quickstart.mdx | Updates client.verify_logic() to use fields that belong only to the migrated low-level LogicVerifier result. |
Reviews (1): Last reviewed commit: "docs: tighten SEO titles on logic engine..." | Re-trigger Greptile
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Summary
Documents the
LogicVerifiermigration to the unifiedDiagnosticResultcontract (v5.4.0) — the second engine to conform afterFactVerifier.Changes
engines/logic.mdx: new "LogicVerifierreturnsDiagnosticResult" section covering the 3-layer output, per-method SAT/UNSAT status matrix for all nine public methods, thesymbol_tabledeveloper field, the two newBLOCKEDconstraint IDs (logic_verifier.explicit_declarations_required,dsl_compiler.type_validation), and before/after migration snippets.getting-started/quickstart.mdx: updated the logic snippet fromresult.status == "SAT"/result.modeltoresult.is_verifiedandresult.developer_fields.changelog.mdx: new v5.4.0 entry summarizing the breaking change for directLogicVerifiercallers, the fail-closed input-strictness fixes, and migration guidance.Context
Source PR: qwed-ai/qwed-verification#262 —
feat: migrate LogicVerifier to DiagnosticResult (Phase 2).