Skip to content

Update from code changes: LogicVerifier DiagnosticResult migration - #250

Open
mintlify[bot] wants to merge 2 commits into
mainfrom
mintlify/a1106bd1
Open

Update from code changes: LogicVerifier DiagnosticResult migration#250
mintlify[bot] wants to merge 2 commits into
mainfrom
mintlify/a1106bd1

Conversation

@mintlify

@mintlify mintlify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Documents the LogicVerifier migration to the unified DiagnosticResult contract (v5.4.0) — the second engine to conform after FactVerifier.

Changes

  • engines/logic.mdx: new "LogicVerifier returns DiagnosticResult" section covering the 3-layer output, per-method SAT/UNSAT status matrix for all nine public methods, the symbol_table developer field, the two new BLOCKED constraint IDs (logic_verifier.explicit_declarations_required, dsl_compiler.type_validation), and before/after migration snippets.
  • getting-started/quickstart.mdx: updated the logic snippet from result.status == "SAT" / result.model to result.is_verified and result.developer_fields.
  • changelog.mdx: new v5.4.0 entry summarizing the breaking change for direct LogicVerifier callers, the fail-closed input-strictness fixes, and migration guidance.

Context

Source PR: qwed-ai/qwed-verification#262feat: migrate LogicVerifier to DiagnosticResult (Phase 2).

@codeant-ai

codeant-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Skipping PR review because a bot author is detected.

If you want to trigger CodeAnt AI, comment @codeant-ai review to trigger a manual review.

@qwed-security

qwed-security Bot commented Jul 30, 2026

Copy link
Copy Markdown

QWED Security Verification Report

3 files scanned | 0 blocked | 0 warnings | 3 info | 0 suppressed | 1 verified

Informational Findings

File Line Context Issue
engines/logic.mdx L187 DOCUMENTATION eval() executes untrusted code. In agentic pipelines, LLM- or caller-controlled expressions reach this sink.
getting-started/quickstart.mdx L15 DOCUMENTATION Hardcoded credential-like material detected.
getting-started/quickstart.mdx L66 DOCUMENTATION os.system() shell execution primitive detected.

Engines

  • entropy_scan: ✅
  • pattern_scan: ⚠️ 3 finding(s)

Verified Files

  • changelog.mdx

Verified by QWED — deterministic security verification. No LLM used.

@dosubot

dosubot Bot commented Jul 30, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-08-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about docs Add Dosu to your team

@mintlify

mintlify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
qwed-ai 🟢 Ready View Preview Jul 30, 2026, 4:13 AM

Comment on lines +45 to +47
print(result.is_verified) # True
print(result.developer_fields["deterministic_verdict"]) # "SAT"
print(result.developer_fields["model"]) # {"x": "6", "y": "9"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Quickstart uses the wrong result contract

When users run either updated client.verify_logic() example, the code accesses is_verified and developer_fields even though the high-level client retains its SAT/UNSAT/UNKNOWN response shape, causing attribute errors before the logic quickstart can complete.

@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown

Greptile Summary

Documents the low-level LogicVerifier migration to the unified DiagnosticResult contract.

  • Adds the v5.4.0 release notes and direct-caller migration guidance.
  • Adds the nine-method status matrix, diagnostic fields, and strict-input behavior.
  • Updates the quickstart logic example, but incorrectly applies the low-level result contract to the unchanged high-level client.

Confidence Score: 3/5

The PR should not merge until the quickstart is restored to the unchanged high-level client response contract.

The updated quickstart accesses DiagnosticResult fields on client.verify_logic(), even though the same PR explicitly documents that this high-level client retains its prior SAT/UNSAT/UNKNOWN response shape.

Files Needing Attention: getting-started/quickstart.mdx

Important Files Changed

Filename Overview
changelog.mdx Adds v5.4.0 release notes and correctly scopes the breaking result-contract change to direct LogicVerifier callers.
engines/logic.mdx Adds comprehensive DiagnosticResult migration documentation and confirms that the high-level client response remains unchanged.
getting-started/quickstart.mdx Updates client.verify_logic() to use fields that belong only to the migrated low-level LogicVerifier result.

Reviews (1): Last reviewed commit: "docs: tighten SEO titles on logic engine..." | Re-trigger Greptile

@mintlify

mintlify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
qwed-ai 🟡 Building Jul 30, 2026, 4:12 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants