Document PRISM refactor review stack - #81
Open
kiwidream wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb8eb53edc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
kiwidream
force-pushed
the
prism-final-ownership-cleanup
branch
from
July 20, 2026 14:42
ffb0ff8 to
7a18a8b
Compare
kiwidream
force-pushed
the
prism-refactor-documentation
branch
2 times, most recently
from
July 20, 2026 15:28
31afdab to
5e7ee7b
Compare
kiwidream
force-pushed
the
prism-final-ownership-cleanup
branch
2 times, most recently
from
July 20, 2026 15:34
2410870 to
8453bc5
Compare
kiwidream
force-pushed
the
prism-refactor-documentation
branch
2 times, most recently
from
July 20, 2026 16:02
3002adc to
9929df7
Compare
kiwidream
force-pushed
the
prism-final-ownership-cleanup
branch
from
July 20, 2026 16:58
020f800 to
f71730b
Compare
kiwidream
force-pushed
the
prism-refactor-documentation
branch
from
July 20, 2026 16:58
9929df7 to
eeeb32b
Compare
kiwidream
force-pushed
the
prism-final-ownership-cleanup
branch
from
July 22, 2026 13:50
f71730b to
59913ce
Compare
kiwidream
force-pushed
the
prism-refactor-documentation
branch
from
July 22, 2026 13:50
eeeb32b to
6016cc1
Compare
kiwidream
force-pushed
the
prism-final-ownership-cleanup
branch
from
July 22, 2026 14:05
59913ce to
867781e
Compare
kiwidream
force-pushed
the
prism-refactor-documentation
branch
from
July 22, 2026 14:05
6016cc1 to
f4f6773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Position in the stack
PR 9 of 9. Base:
prism-final-ownership-cleanup. Depends on PR 80.This PR is the documentation and final-evidence slice. Review and merge the stack bottom-up if the slices are landed individually. The stack guide records the complete order and reconstruction rules.
Why this slice exists
The refactor changes internal ownership, review structure, validation cadence, and an existing-database migration. Those contracts need to remain understandable after the implementation discussion is gone. This slice makes the completed architecture, invariants, decisions, operations, and evidence part of the repository.
What changes
001_share_ledger.sqlmigration, lock impact, application procedure, and reactivation ordinal behavior.Reading the diff
This is a small documentation-only slice: about 560 additions and five deletions across 11 files. The only production-file change is a comment clarifying that reactivation reuses an already-published audit ordinal. Review the documents against the final owner modules and migration behavior; there is no runtime implementation hidden in this PR.
Final validation
qbit-prism: 182 passed.UNAVAILABLEbecause the OrbStack Docker daemon is stopped. Lint was not run outside Docker.UNAVAILABLE: their doctor stops at the unreachable Docker daemon, andqbitd/qbit-cliare also absent.Operator impact
Existing PostgreSQL deployments must follow
docs/prism-ledger-ops.mdbefore upgrade. The migration usesACCESS EXCLUSIVEDDL, a later serializedSHARE ROW EXCLUSIVEphase, and a non-concurrent unique index, so it requires a reviewed maintenance window or a stopped old coordinator.Landing state
The reviewed stack is integrated with
origin/1.x.xatb002caa. Retry pacing (#71), delivery-health grace (#82), and share hot-path lock isolation (#83) are ported into the extracted template, refresh, candidate, session, submission, vardiff, delivery, ledger, observability, and metrics owners without restoring domain logic toprism_coordinator.py.Note
Low Risk
Documentation and index cross-links only, plus a non-behavioral comment in production code; operator migration steps are advisory and do not change runtime logic in this PR.
Overview
Adds a PRISM coordinator refactor documentation tree under
docs/prism-coordinator-refactor/: completion status, release invariants, final owner map, validation evidence, nine-PR stack guide, A1 audit-artifact contract, and the decision to omit B3.Operator and ledger guidance expands
docs/prism-ledger-ops.mdandcrates/qbit-prism/README.md: cumulative idempotent001_share_ledger.sql,audit_publication_sequencemigration (locks,psqlprocedure, reactivation reusing published ordinals), finalize-only outbox replay when the network outcome is already known, and cross-links fromdocs/README.md.The only runtime change is a comment in
block_finalization.pyclarifying that reactivation keeps an already-published audit ordinal rather than allocating a new one.Reviewed by Cursor Bugbot for commit f4f6773. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.