This repository was archived by the owner on May 11, 2019. It is now read-only.
define NOMINMAX so that std::min and std::max may be used - #11
Open
pauloscustodio wants to merge 1 commit into
Open
define NOMINMAX so that std::min and std::max may be used#11pauloscustodio wants to merge 1 commit into
pauloscustodio wants to merge 1 commit into
Conversation
Owner
|
I don't feel comfortable defining this, as users may not want this. Why not define it yourself in your own code prior to including filesystem? This will break a lot of people. |
Author
|
This is what I have done. Maybe add a note in the README? The compilation error is a bit obscure; I got : where the offending line reads: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this define, sources using std::min and std::max and including filesystem.hpp in Windows do not compile.