Conversation
Member
Author
|
@giannipetrella This is a Claude-assisted implementation of Raf's smoothness check. Let's review this carefully, and then we have another very useful feature ready. |
Member
|
Three remarks:
|
This was referenced Aug 25, 2026
Member
Author
|
Nullcones have been split off into #48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Bocklandt reduction (MR1929191) and the classification of cofree quiver settings by Bocklandt and Van de Weyer (doi:10.1016/j.jalgebra.2007.08.019), and applies them to the geometry of quiver moduli spaces.
strongly_connected_componentsfor quivers;bocklandt_reductionandis_coregularfor quiver settings, with the reduction steps documented against Bocklandt's paper;is_smoothfor moduli spaces with properly semistable representations, by checking coregularity of every local quiver setting (MR1972892);codimension_singular_locus, using that the singular locus is a union of Luna strata;is_cofree, via wedging, prime components, and the classification lists.Luna-type consumers validate positive multiplicities, nonzero dimension vectors, stable rather than merely semistable summands, and the rigidity restriction on repeated distinct summands. Fixed-shape quiver-setting results are returned as named tuples.
Tests include the ten nodes of the Segre cubic, the accidental isomorphism to
Gr(2, 4)for the 6-subspace quiver on a wall, andP^5for the 3-Kronecker quiver with dimension vectors(2, 2)and(2, 4). Regression tests cover invalid Luna encodings, dimension-vector contracts, and longer Boolean reachability paths.The nullcone, Lefschetz-motive, and wall-projection functionality formerly included here has moved to the stacked PR #48, so this PR can be reviewed and merged independently. The branch has been rebuilt onto the current
mainand is mergeable.