fix(tts): text_to_speech.py __main__ block passes a max_accelerate_audio kwarg that no longer exists - #205
Open
Anai-Guo wants to merge 1 commit into
Open
Conversation
… smoke test audio_segmentation_to_voice() does not take max_accelerate_audio - that parameter belongs to accelerate_segments(). Running text_to_speech.py directly raises TypeError before any TTS work happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
soni_translate/text_to_speech.pydirectly fails immediately:Why the kwarg is the stale side
max_accelerate_audiois a parameter ofaccelerate_segments()(text_to_speech.py:1089-1091,used at
:1162-1163to clampacc_percentage), not ofaudio_segmentation_to_voice()(
:969, whose parameters areresult_diarize, TRANSLATE_AUDIO_TO, is_gui, tts_voice00..11, dereverb_automatic, model_id_bark, model_id_coqui, delete_previous_automatic).The pipeline in
app_rvc.pyreflects that split: it passesmax_accelerate_audiotoaccelerate_segments(app_rvc.py:989-994) and callsaudio_segmentation_to_voicepositionally with only the 15 arguments it actually declares (
app_rvc.py:955-970). The__main__block is the only call site that still hands acceleration to the TTS function.Fix
Delete that one argument. Nothing else in the block changes, and no non-
__main__code pathis touched.
Verification
Extracted the real signature with
astand replayed both call sites withinspect.Signature.bind:🤖 Generated with Claude Code