Emissions lineplots - #660
Conversation
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-660.westus2.2.azurestaticapps.net |
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-660.westus2.2.azurestaticapps.net |
|
I think the plots would have to have a fixed lower bound of the y-axis at zero, at least for absolute emissions |
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-660.westus2.2.azurestaticapps.net |
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-660.westus2.2.azurestaticapps.net |
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-660.westus2.2.azurestaticapps.net |
Expected version change and release notes🚨 WARNING: This PR is not expected to trigger a new versionTo trigger a version bump, use at least one conventional commit message in this branch. See: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-glacier-0f640931e-660.westus2.2.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Updates the emissions visualizations to use line plots by routing emissions-related plot types through the existing MultiLineChart component and adapting MultiLineChart’s series grouping for emissions metrics.
Changes:
- Switch
absoluteEmissionsandemissionsIntensityplots inPlotSelectorfromVerticalBarCharttoMultiLineChart. - Adjust
MultiLineChartdata preprocessing to support emissions metrics by remapping the series key viatechnology.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/PlotSelector.tsx | Routes emissions plot types to MultiLineChart and removes the unused VerticalBarChart import. |
| src/components/MultiLineChart.tsx | Updates memoized filtering/grouping preparation to support emissions metrics in a line chart. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (metric == "emissionsIntensity" || metric == "absoluteEmissions") { | ||
| filtered = filtered.map((d) => ({ ...d, technology: d.metric })); | ||
| } | ||
| return filtered; | ||
| }, [data.data, sector, metric]); |
|
@jacobvjk is this something we can either wrap up or close out? |
No description provided.