Skip to content

feat: optional stake and accurate seed data (STIT-528, STIT-562) - #223

Open
mbarlow12 wants to merge 3 commits into
mainfrom
fix/seed-json-data
Open

feat: optional stake and accurate seed data (STIT-528, STIT-562)#223
mbarlow12 wants to merge 3 commits into
mainfrom
fix/seed-json-data

Conversation

@mbarlow12

Copy link
Copy Markdown
Contributor
  • adds owner/operator seed data
  • makes stake for owners/operators optional, w/ tests & UI adjustments

AI usage: root cause investigation in stitch-etl-poc, CC implementation here was straightforward

Most provider ownership data is a bare company name with no percentage, so a
required stake forced either fabrication or dropping the party.

- OilGasOwner.stake / OilGasOperator.stake are now FractionalPercentage | None
- ResourceDetailPage leaves the Stake card blank instead of rendering "null%"
- No migration: owners/operators persist as JSON blobs
- Faker payloads emit owners with stated stakes and operators as names only,
  exercising both the stated and null stake paths locally
- region now draws from the canonical 7-value vocabulary the ETL emits, not
  fake.city(), which made the Region filter dropdown nonsense
- Static mock data gains real owners/operators, including multi-source records
  so the merge and priority views have something to coalesce
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

CD summary d75bfe2

Frontend: https://witty-mushroom-017a3dc1e-223.westus2.1.azurestaticapps.net

Deployments (4)
service url fqdn
api open pr-0223-api.purplegrass-c07d0a94.westus2.azurecontainerapps.io
entity-linkage open pr-0223-el.purplegrass-c07d0a94.westus2.azurecontainerapps.io
frontend https://witty-mushroom-017a3dc1e-223.westus2.1.azurestaticapps.net
stitch-llm open pr-0223-llm.purplegrass-c07d0a94.westus2.azurecontainerapps.io
Database (1)
db_name postgres_host postgres_port postgres_db
pr_0223 stitch-dev.postgres.database.azure.com 5432 pr_0223
Jobs (2)
job image postgres_db api_url auth_mode
db-migrations ghcr.io/rmi/stitch-api:pr-0223@sha256:c29fc584c2b2a519d0ea64d31f8ead21c6890aa8039bd61c9856e0d21b7dd22b pr_0223
seed ghcr.io/rmi/stitch-seed:pr-0223@sha256:7736722d02617361de901e1fe9d75ede70d0f299b23943de6d9d6b97a44beaab https://pr-0223-api.purplegrass-c07d0a94.westus2.azurecontainerapps.io/api/v1 stitch-client-bearer-token
Images (4)
build_time commit_time git_sha image image_digest
2026-08-05T20:21:15Z 2026-08-05T20:20:53Z 3b3233f ghcr.io/rmi/stitch-api:pr-0223 ghcr.io/rmi/stitch-api:pr-0223@sha256:c29fc584c2b2a519d0ea64d31f8ead21c6890aa8039bd61c9856e0d21b7dd22b
2026-08-05T20:21:18Z 2026-08-05T20:20:53Z 3b3233f ghcr.io/rmi/stitch-entity-linkage:pr-0223 ghcr.io/rmi/stitch-entity-linkage:pr-0223@sha256:196952379b5b4e05e0af5a7bc81ae7f8b2646ace5891e373a6c6975b4b3d72c2
2026-08-05T20:21:20Z 2026-08-05T20:20:53Z 3b3233f ghcr.io/rmi/stitch-seed:pr-0223 ghcr.io/rmi/stitch-seed:pr-0223@sha256:7736722d02617361de901e1fe9d75ede70d0f299b23943de6d9d6b97a44beaab
2026-08-05T20:21:16Z 2026-08-05T20:20:53Z 3b3233f ghcr.io/rmi/stitch-stitch-llm:pr-0223 ghcr.io/rmi/stitch-stitch-llm:pr-0223@sha256:a48c50cd3bb127970aaf245e183c76212cf5dd5943689f981dda6e9074ac1d98

The static fixtures carried region strings from three different vocabularies
(Oceania, North Sea, Gulf Coast, Sub-Saharan Africa), so the local Region filter
offered 12 options for 7 geographies and obscured verification.

Each region is now the canonical value for that record's own country, matching
what the ETL emits. The explicit null on the rmi record is kept as a no-region
case. 004-merge-demo.json's "WM FIELD LABEL" is left alone — it demonstrates
per-source field labelling, not a real region.
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

CD summary 7dc1c17

Frontend: https://witty-mushroom-017a3dc1e-223.westus2.1.azurestaticapps.net

Deployments (4)
service url fqdn
api open pr-0223-api.purplegrass-c07d0a94.westus2.azurecontainerapps.io
entity-linkage open pr-0223-el.purplegrass-c07d0a94.westus2.azurecontainerapps.io
frontend https://witty-mushroom-017a3dc1e-223.westus2.1.azurestaticapps.net
stitch-llm open pr-0223-llm.purplegrass-c07d0a94.westus2.azurecontainerapps.io
Database (1)
db_name postgres_host postgres_port postgres_db
pr_0223 stitch-dev.postgres.database.azure.com 5432 pr_0223
Jobs (1)
job image postgres_db
db-migrations ghcr.io/rmi/stitch-api:pr-0223@sha256:cbfd819f36fe7353c1e3f9c33c704a1d1f5f5875287c3d9d7ae8a356017745cb pr_0223
Images (4)
build_time commit_time git_sha image image_digest
2026-08-05T22:06:19Z 2026-08-05T22:05:59Z 24cd62c ghcr.io/rmi/stitch-api:pr-0223 ghcr.io/rmi/stitch-api:pr-0223@sha256:cbfd819f36fe7353c1e3f9c33c704a1d1f5f5875287c3d9d7ae8a356017745cb
2026-08-05T22:06:13Z 2026-08-05T22:05:59Z 24cd62c ghcr.io/rmi/stitch-entity-linkage:pr-0223 ghcr.io/rmi/stitch-entity-linkage:pr-0223@sha256:d543d526c708922b43092e0eb47e6498f17d5a484985445b0a95d559477178fa
2026-08-05T22:06:13Z 2026-08-05T22:05:59Z 24cd62c ghcr.io/rmi/stitch-seed:pr-0223 ghcr.io/rmi/stitch-seed:pr-0223@sha256:0373afd9ecb94d062196089f29f531174c9d025fd39f9c81e3bc87241108079a
2026-08-05T22:06:16Z 2026-08-05T22:05:59Z 24cd62c ghcr.io/rmi/stitch-stitch-llm:pr-0223 ghcr.io/rmi/stitch-stitch-llm:pr-0223@sha256:34903abdb68d731ff371c3bac61d646cd252c2ea79c066ae6ea1f852e3a3ebd1

@AlexAxthelm AlexAxthelm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentatively approved, pending discussion of commas in company names


def _company(fake: Faker) -> str:
# Faker likes commas in company names; drop them to keep values simple.
return fake.company().replace(",", "")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able be able to handle commas in company names? seems like a blocker in that these should get escaped, not dropped.

"region": "Russia and Caspian Sea",
"basin": "North Sea",
"owners": [
{"name": "KazMunayGas", "stake": null},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: Noting that the owners appear to be respecting the coalesce rules correctly (wm owners are presented rather than GEM ones), but these info cards aren't the same as the other fields (no click to see all values or edit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants