Skip to content

refactor(test): restructure tests/ by deployment target - #316

Merged
sgopinath1 merged 1 commit into
ROCm:mainfrom
shiv-tyagi:refactor/restructure-e2e-tests
Jun 20, 2026
Merged

refactor(test): restructure tests/ by deployment target#316
sgopinath1 merged 1 commit into
ROCm:mainfrom
shiv-tyagi:refactor/restructure-e2e-tests

Conversation

@shiv-tyagi

@shiv-tyagi shiv-tyagi commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary

Reorganizes the test directory layout from tests/e2e/{native_host,k8s}/ to tests/{native_host,k8s}/e2e/ so each deployment target is a top-level directory that can host multiple test categories sharing common fixtures.

New layout:

tests/
├── conftest.py
├── pytest.ini
├── requirements.txt
├── README.md
├── native_host/
│   └── e2e/          ← was tests/e2e/native_host/
└── k8s/
    └── e2e/          ← was tests/e2e/k8s/

Changes

  • Move tests/e2e/native_host/tests/native_host/e2e/
  • Move tests/e2e/k8s/tests/k8s/e2e/
  • Move shared files (pytest.ini, conftest.py, requirements.txt, README.md) up to tests/
  • Update .github/workflows/e2e.yml and ci.yml with new paths
  • Update docs/developer/building.rst with new paths
  • Update pythonpath in pytest.ini to ensure module imports continue working

Test plan

  • CI workflows pass
  • pytest tests/native_host/e2e/ --collect-only collects 81 tests (module imports resolve)
  • pytest tests/k8s/e2e/ --collect-only collects 13 tests
  • No stale tests/e2e references remain (repo-wide grep)

@shiv-tyagi
shiv-tyagi marked this pull request as ready for review June 20, 2026 08:41
Copilot AI review requested due to automatic review settings June 20, 2026 08:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov-commenter

codecov-commenter commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   65.11%   65.11%           
=======================================
  Files         121      121           
  Lines       32346    32346           
=======================================
  Hits        21059    21059           
  Misses      11287    11287           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Reorganize from tests/e2e/{native_host,k8s}/ to
tests/{native_host,k8s}/e2e/ so each deployment target is a top-level
directory that can host multiple test categories (e2e, stress, etc.)
sharing common fixtures.

New layout:
  tests/native_host/e2e/  (was tests/e2e/native_host/)
  tests/k8s/e2e/          (was tests/e2e/k8s/)

Updates CI workflows, docs, pytest.ini, and all path references.
Adds `stress` marker to pytest.ini for upcoming stress harness.
Native-host CI now runs with `-m "not stress"` so stress tests are
opt-in.
@shiv-tyagi
shiv-tyagi force-pushed the refactor/restructure-e2e-tests branch from 7a52903 to 7d3ef0f Compare June 20, 2026 08:48

@sgopinath1 sgopinath1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgopinath1
sgopinath1 merged commit 0779957 into ROCm:main Jun 20, 2026
12 of 14 checks passed
sgopinath1 added a commit to sgopinath1/spur that referenced this pull request Jun 20, 2026
Align printed harness location with PR ROCm#316 layout (native_host/e2e).
yansun1996 pushed a commit to yansun1996/spur that referenced this pull request Jun 24, 2026
Reorganize from tests/e2e/{native_host,k8s}/ to
tests/{native_host,k8s}/e2e/ so each deployment target is a top-level
directory that can host multiple test categories (e2e, stress, etc.)
sharing common fixtures.

New layout:
  tests/native_host/e2e/  (was tests/e2e/native_host/)
  tests/k8s/e2e/          (was tests/e2e/k8s/)

Updates CI workflows, docs, pytest.ini, and all path references.
Adds `stress` marker to pytest.ini for upcoming stress harness.
Native-host CI now runs with `-m "not stress"` so stress tests are
opt-in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants