feat(ops): abstract op groups with TOML-driven concrete instances

[jellllly420]

Summary

Adds ops { ... } blocks to .rpl patterns and [[ops.<group>]] instances in rpl.toml. A single abstract pattern can describe operations such as locking or intrusive-list transfer across several concrete implementations without duplicating its body.

pattern lock_unlock
ops {
    sync[$T: type, $U: type] = {
        fn $lock(&mut $T) -> $U;
    }
}
patt {
    p[$U: type] = fn _ (..) -> _ {
        'lock:
        let $guard: $U = $sync::$lock(move _);
    }
}

[[ops.sync]]
type = ["$1"]
T = "std::sync::Mutex<$1>"
U = "std::sync::MutexGuard<$1>"
lock = "$T::lock"

The driver expands type placeholders in configured paths and tries each combination of instances for the groups referenced by a pattern. No referenced groups means one ordinary matching attempt; a referenced group with no valid instances produces no matches. Invalid instances are skipped while valid instances remain available.

Implementation

• Parser and AST support for op-group signatures and $group::$op call operands. ops remains valid in ordinary paths such as core::ops::Range.
• R1–R6 well-formedness checks, including declared operation references, call arity, and preventing op-level metavariables from leaking into pattern bodies.
• TOML instance deserialization, placeholder expansion, and instance validation.
• OnceCell stores collected op references without mutating through shared references.
• An ops-only rpl.toml retains the built-in pattern fallback instead of setting RPL_PATS to an empty string.

Rebased onto master at 6fb85147beebab261f1df22db9dccf35f4ead641. Matching now uses master's MatchSession pipeline: each complete pattern item gets one Cartesian assignment, shared by every function slot and nested positive/negative set-operation operand. Sessions with ops bindings bypass the shared function-candidate cache, whose key does not identify the assignment. Ordinary patterns retain master's cache and matching behavior.

Tests

Unit and integration coverage exercises parsing, lowering, well-formedness, configuration loading, placeholder resolution, referenced-group collection, and Cartesian expansion.

The UI harness now registers tests/features/ops and tests/features/ops_cve_2025_68260, with per-file pattern selection and generated stderr expectations. The zero-instance fixture's invalid primary label is repaired. These seven cases check ordinary matching, empty groups, partially invalid configuration, set subtraction, multiple groups, and the CVE model's buggy/fixed pair. They compile fixtures without executing them.

Four additional cases in tests/ui/session/ops cover:

• Both Mutex and RwLock instances matching without candidate-cache contamination.
• Two function slots sharing an instance.
• Rejecting a pair of slots that require different instances.
• Nested set subtraction preserving the selected instance, including a covered negative control and a nested exemption.

Local validation on macOS with nightly-2025-02-14:

• cargo test --workspace --exclude lintcheck: passed, 415 tests including 230 UI cases; 19 UI cases ignored.
• RPL_PATS=docs/patterns-pest cargo test --workspace --exclude lintcheck: passed with the same counts.
• All 11 ops UI cases passed in both modes.
• cargo clippy --workspace --all-targets -- -D warnings: passed.
• cargo fmt --all -- --check: passed.
• python3 scripts/check_rpl_patterns.py: passed.

The full cargo test --workspace run was stopped after lintcheck spent over five minutes analyzing third-party cc 1.0.67. A stack sample showed MIR dependency-graph construction; that smoke test is not reported as passed. GitHub CI validates the other host platforms separately.

Remaining limitations

• Resolver diagnostics are collected but not yet emitted as rustc diagnostics.
• The reserved TOML key type can collide with an operation name.
• Placeholder expansion uses a bounded iteration count rather than explicit cycle detection.
• Op paths match function DefIds after stripping generic arguments; this does not establish concrete signature-type constraints. UFCS paths are not supported by the current string splitter.
• Op-reference collection does not yet traverse impl-function bodies.
• Some ops diagnostic spans still use DUMMY_SP.
• ResolvedOpBindings::from_combo clones instances; shared ownership could reduce per-attempt cost.
• Additional resolver error-path tests and cleanup of the empty-selection branch in resolve_patterns remain useful follow-ups.

crates/rpl_parser/src/parser.rs is generated from RPL.pest; review the grammar changes rather than the generated parser expansion.

Generated by Codex (GPT-6) on behalf of @jellllly420

[Copilot]

Pull request overview

Adds “abstract ops” to the RPL toolchain: .rpl patterns can declare parameterized op groups in a new ops { ... } block and reference them via $group::$op, while concrete instances are supplied via [[ops.<group>]] in rpl.toml. The driver/matcher then iterates over the cartesian product of referenced op-group instances and resolves $group::$op to concrete Rust DefIds during MIR matching.

Changes:

• Extend the parser/grammar and pattern IR to support ops { ... } blocks and OpRef operands ($group::$op).
• Load [[ops.<group>]] instances from rpl.toml, resolve/expand them, and thread op bindings through the matcher/driver with cartesian-product enumeration.
• Add unit/integration tests plus end-to-end “features” fixtures (including a CVE POC) and a design spec document.

Reviewed changes

Copilot reviewed 49 out of 51 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/features/test.sh	Expands the manual features test script to run new ops fixtures; adjusts shell strictness.
tests/features/ops/two_groups.rs	New feature fixture exercising cartesian matching across two op groups.
tests/features/ops/two_groups.rpl	New pattern using two op refs (sync_2g and logger_2g).
tests/features/ops/set_op_with_ops.rs	New feature fixture covering set-op subtraction with ops-based util patterns.
tests/features/ops/set_op_with_ops.rpl	New pattern demonstrating p_lock - p_uncovered with op refs.
tests/features/ops/partial_bad.rs	New feature fixture for “skip malformed instance, keep others” behavior.
tests/features/ops/partial_bad.rpl	New pattern for partial-bad instance scenario.
tests/features/ops/lock_unlock.rs	New basic feature fixture for a single op group instance.
tests/features/ops/lock_unlock.rpl	New lock pattern referencing $sync::$lock.
tests/features/ops/folded.rs	New fixture verifying fold-to-zero when no instances exist.
tests/features/ops/folded.rpl	New “folded” pattern referencing an op group with no instances.
tests/features/ops_cve_2025_68260/pattern.rpl	New multi-group ops pattern modelling the CVE bug class.
tests/features/ops_cve_2025_68260/fixed.rs	New “fixed” variant fixture that should not match.
tests/features/ops_cve_2025_68260/buggy.rs	New “buggy” variant fixture that should match.
rust-toolchain	Adds rust-analyzer component to the pinned nightly toolchain config.
rpl.toml	Adds workspace ops instances ([[ops.*]]) used by feature fixtures.
docs/superpowers/specs/2026-04-28-abstract-ops-design.md	Design doc describing the abstract-ops feature and validation/matching model.
crates/rpl_resolve/tests/ops_resolve.rs	Adds resolver-side tests for ops WF / op-ref checks (delegating to rpl_context).
crates/rpl_resolve/Cargo.toml	Adds dev-dependencies needed by new tests.
crates/rpl_parser/tests/test.rs	Adds parser tests for opsBlock and OpRef parsing.
crates/rpl_parser/src/grammar/RPL.pest	Extends grammar with opsBlock, opsItem, OpFnDecl, and OpRef.
crates/rpl_meta/src/meta.rs	Updates block collection to include ops blocks.
crates/rpl_meta/src/check.rs	Updates MIR operand checking for the new OpRef grammar variant.
crates/rpl_match/src/statement.rs	Adds runtime OpRef matching that resolves to MIR DefId via expanded paths.
crates/rpl_match/src/mir.rs	Threads op bindings into MIR matching context.
crates/rpl_match/src/matches/color.rs	Threads op bindings into the “color” matcher context.
crates/rpl_driver/tests/ops_threading.rs	Smoke test ensuring ops config threading compiles and can be empty.
crates/rpl_driver/tests/cartesian.rs	Unit tests for the new cartesian-product helper.
crates/rpl_driver/src/lib.rs	Loads raw ops from rpl.toml, resolves them, iterates cartesian products, and threads bindings into matching.
crates/rpl_driver/Cargo.toml	Adds dependency on rpl_config for ops loading.
crates/rpl_context/tests/referenced_op_groups.rs	Tests referenced op-group collection in lowered patterns.
crates/rpl_context/tests/ops_wf.rs	Tests ops-block WF checks (R1–R3).
crates/rpl_context/tests/ops_resolution.rs	Tests ops instance substitution/validation (resolve_ops_config).
crates/rpl_context/tests/ops_lowering.rs	Tests lowering of ops blocks into Pattern.ops_block.
crates/rpl_context/src/pat/ops.rs	Introduces OpsBlock, OpGroup, and OpSignature IR structures.
crates/rpl_context/src/pat/ops_wf.rs	Implements WF checks (R1–R3) plus parse-tree R6 helper.
crates/rpl_context/src/pat/ops_uses.rs	Implements post-lowering op-ref use-site checks (R4–R5) and group collection.
crates/rpl_context/src/pat/ops_resolved.rs	Implements ops instance expansion/validation and per-attempt bindings structures.
crates/rpl_context/src/pat/mod.rs	Integrates ops blocks/op refs into the pattern IR and population pipeline.
crates/rpl_context/src/pat/mir/visitor.rs	Updates visitor to traverse the new Operand::OpRef variant.
crates/rpl_context/src/pat/mir/pretty.rs	Adds formatting/debug output for Operand::OpRef.
crates/rpl_context/src/pat/mir/mod.rs	Adds Operand::OpRef and parsing/lowering support for it.
crates/rpl_context/src/context.rs	Wires ops blocks into pattern loading and triggers op-ref validation/population.
crates/rpl_context/Cargo.toml	Adds rpl_config dependency for ops instance types in context/tests.
crates/rpl_config/tests/ops_loading.rs	Adds TOML deserialization tests for ops instances.
crates/rpl_config/src/patterns.rs	Fixes empty resolved pattern paths mapping to avoid RPL_PATS="" failures.
crates/rpl_config/src/ops.rs	Adds RawOpInstance TOML deserializer (type = [...] + string bindings).
crates/rpl_config/src/lib.rs	Exposes ops loading (load_raw_ops) and adds ops to config schema.
Cargo.lock	Updates lockfile for new/changed crate dependencies.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jellllly420]

@TheVeryDarkness ready for another look when you have time — both of your comments have been addressed:

• tests/ops_lowering.rs:47 (Box::leak duplication): collapsed into shared tests/common/mod.rs helpers (make_static_mctx + a LazyLock<&'static Arena<'static>>) in c783ea7. Eight call sites across five test files now go through the helpers; all 34 ops integration tests still pass.
• rust-toolchain:3 (rust-analyzer addition): reverted in a8daebf — it was an inadvertent IDE-tooling addition not needed by cargo build/test/clippy/fmt. rust-toolchain now matches its pre-PR state.

The 6 Copilot threads on the previous round are also disposed of (3 fixed in e8e1ae6/ac0f3c6/73b85f7, 3 deferred-with-rationale into the PR body's "Deferred work" section). All 8 review threads are marked resolved; please re-open any you'd like to discuss further.

CI green on the latest HEAD (c783ea7): both ubuntu and windows passing.

Since GitHub doesn't let fork contributors re-request reviewers, this comment is the closest I can do to a rebadge. Thanks for the careful review!

— Generated by Claude Opus 4.7 (1M context) on behalf of @jellllly420