ROBOT integrity testing - #7
Merged
Merged
Conversation
Bare `if:` expressions get an implicit `&& success()`, which made the artifact-upload steps skip themselves whenever the preceding check step failed. Add failure() to override that default so the artifacts actually get produced.
found with one of the new ROBOT integrity tests
averde15
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add integrity tests that run automatically when we push to this GitHub repository, via a GitHub Action. So far, all of the tests download and use ROBOT. The actual tests are factored out into shell scripts that can also be run locally by developers. They include:
I also included documentation on how the tests work, how they are integrated into CI, how to run them locally/manually, and how to add new ones.
NOTE
Three existing synonyms in RadLex violated the whitespace check. None seemed to be intentional; they are all fixed as part of this PR.
Future work
Once this is merged, we can gate future PR merges on these tests passing.
We can also add more tests in the near future.