Repository navigation
fix: index_stream tail loop ignored QUERY_REMAP - #39
Merged
RagnarGrootKoerkamp merged 2 commits intoAug 28, 2026
Merged
Conversation
The prefetch-ring flush tested REMAP instead of QUERY_REMAP, so index_stream_maybe_remap::<B, false, _> remapped the last B keys on a minimal PHF and disagreed with index_no_remap there.
Owner
|
thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefetch-ring flush at the end of
index_stream_maybe_remaptestsREMAPinstead ofQUERY_REMAP, so on a minimal PHFindex_stream_maybe_remap::<B, false, _>remaps the lastBkeys and disagrees with
index_no_remapthere.index_stream::<B, _>is unaffected — it passesQUERY_REMAP = REMAP.Repro on 2.1.1 and on master: 64 mismatches over 200 builds, all at key index
>= n - B. Zero withthis patch.
Second commit drops a leftover
eprintln!inmax_index_no_remap().cargo test --lib --releasepasses.