fix: don't read the clock on wasm32-unknown-unknown - #41
Merged
RagnarGrootKoerkamp merged 1 commit intoSep 27, 2026
Merged
RagnarGrootKoerkamp merged 1 commit into
RagnarGrootKoerkamp merged 1 commit into
Conversation
PtrHash::new called Instant::now for its build timings even with
logging off, and on wasm32-unknown-unknown that panics ("time not
implemented on this platform"). The timings only feed trace!, so a
small Timer now reads the clock only when trace logging is enabled,
and never on that target. No new dependency.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RuhhXa22BzYGGVpkkVnoco
Owner
|
Released 2.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PtrHash::newcalledInstant::nowfor its build timings even with logging off, and on wasm32-unknown-unknown that panics ("time not implemented on this platform"). The timings only feedtrace!, so a small Timer now reads the clock only when trace logging is enabled, and never on that target.