Introduce skid_steer as a new way to load assets - #515
Merged
Conversation
patowen
force-pushed
the
introduce-skid-steer
branch
3 times, most recently
from
August 22, 2026 02:41
614549c to
656444b
Compare
patowen
commented
Aug 22, 2026
patowen
commented
Aug 22, 2026
patowen
force-pushed
the
introduce-skid-steer
branch
2 times, most recently
from
August 25, 2026 02:21
2ac99ab to
359c1aa
Compare
patowen
marked this pull request as ready for review
August 26, 2026 02:39
Ralith
requested changes
Aug 26, 2026
Ralith
left a comment
Owner
There was a problem hiding this comment.
Review is just getting started, but it may be a few days before I make more progress.
patowen
force-pushed
the
introduce-skid-steer
branch
from
August 28, 2026 04:22
359c1aa to
cd2bff8
Compare
patowen
added a commit
to patowen/hypermine
that referenced
this pull request
Aug 29, 2026
This sets up consistency with Ralith#515
Ralith
approved these changes
Aug 29, 2026
patowen
force-pushed
the
introduce-skid-steer
branch
from
August 29, 2026 23:28
cd2bff8 to
7fdec92
Compare
Collaborator
Author
|
I'll request one more quick review to double-check my latest changes, although based on your previous approval, I'm pretty confident this is safe to merge as-is. |
Ralith
approved these changes
Aug 29, 2026
patowen
force-pushed
the
introduce-skid-steer
branch
from
August 29, 2026 23:55
7fdec92 to
7be06ff
Compare
Ralith
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively significant refactor of Hypermine, switching up asset loading to use a new library called "skid_steer".
It introduces the following changes:
AssetLoadertype is added to drive asset loading, acting as the glue between skid_steer and Hypermine. This completely replaces the oldloadermodule.lahar_deprecatedmodule have been replaced with a vendoredgrowable_ringimplementation from @Ralith, and aParallelQueuefrom the current version of lahar. This allows us to finally remove thelahar_deprecatedmodule, a task that I had hoped to do years ago.Loader, have been migrated to the newAssetLoader.ShaderDatastruct to pass around global data used for rendering.