fix single-hotkey root claim quote

[UnArbosSix]

Description

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
subtensor	Ready	Preview	Aug 21, 2026 2:59pm

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

[HIGH] Single-hotkey claims can execute beyond their declared weight

This reduces the declaration to 129 units, but the call still uses root_claim_fits_declared_budget, whose budget remains MAX_ROOT_CLAIM_WORK (256). A single basket can contain historical/deregistered subnet rows beyond the current 128-subnet limit, so a claim with 130–256 rows passes admission and performs more work than declared. That permits under-accounted block execution and resource-exhaustion attacks. Give this call a 129-unit admission check, including its actual basket-row count, or retain the 256-unit declaration.

Suggested change

	<T as crate::pallet::Config>::WeightInfo::claim_root(crate::MAX_ROOT_CLAIM_HOTKEY_WORK)
	<T as crate::pallet::Config>::WeightInfo::claim_root(crate::MAX_ROOT_CLAIM_WORK)

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: VULNERABLE

HIGH scrutiny: account is under 90 days old with no public repos, though it has repository write access and substantial merged contributions; no Gittensor association found; branch fix/root-claim-hotkey-quote -> release-448.

Findings

Sev	File	Finding
HIGH	pallets/subtensor/src/macros/dispatches.rs:1991	Single-hotkey claims can exceed their declared weight	inline

Prior-comment reconciliation

• b79553f1: not addressed — The declaration remains 129, while the invoked admission helper still uses the 256-unit coldkey-wide budget.

Conclusion

The prior vulnerability remains: the single-hotkey call declares only 129 work units while its unchanged admission check permits up to 256. The declared weight and admission ceiling must match before merge.

---

📜 Previous run (superseded)

Sev	File	Finding	Status
HIGH	pallets/subtensor/src/macros/dispatches.rs:1991	Single-hotkey claims can execute beyond their declared weight	➡️ Carried forward to current findings The declaration remains 129, while the invoked admission helper still uses the 256-unit coldkey-wide budget.

---

# 🔍 AI Review — Auditor (domain review) has not yet run on this PR.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE