Skip to content

Update lencode and safe-bigmath - #3107

Open
UnArbosFour wants to merge 3 commits into
release-449from
chore/update-lencode
Open

Update lencode and safe-bigmath#3107
UnArbosFour wants to merge 3 commits into
release-449from
chore/update-lencode

Conversation

@UnArbosFour

@UnArbosFour UnArbosFour commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Motivation

Update safe-bigmath to its 0.4.2 revision and align the workspace's lencode dependency with the version required by that release.

Changes

  • Updated the pinned safe-bigmath Git revision from 0.4.1 to 0.4.2.
  • Updated lencode and lencode-macros from 0.1.6 to 1.2.1.
  • Regenerated Cargo.lock to capture the resulting transitive dependency changes.

Behavioral impact

No Subtensor source code or public API is changed directly. The updated libraries are used by the swap pallet's high-precision arithmetic implementation, so existing swap tests and workspace CI should validate compatibility.

Migration and spec version

No storage migration is required. The PR targets release-449, which has no corresponding live-network spec-version check, so this dependency-only change does not include a spec-version bump.

Validation

The lockfile is consistent with the manifest changes, and git diff --check passes. Full compilation and tests are delegated to CI; local Cargo validation was unavailable because the existing toolchain/cache directories were read-only.

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
subtensor Ready Ready Preview Aug 21, 2026 4:58pm

Request Review

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

VERY HIGH scrutiny (account under 90 days and one public repository), mitigated by repository write access; no Gittensor association found; branch chore/update-lencode → release-449.

Static analysis covered the complete dependency-only diff. Both direct updates are immutably resolved by a Git revision or registry checksum; no review trust-boundary, runtime logic, origin, or CI workflow changes are present.

Findings

No findings.

Conclusion

No malicious behavior or concrete security vulnerability was found in the dependency update.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

UNKNOWN Gittensor association; newer account with substantial repository activity and write access.

This remains a coherent, lockfile-complete dependency update: safe-bigmath 0.4.2 and its required lencode 1.2.1 release move together. The overlapping PRs only share workspace manifests and are not functional duplicates.

git diff --check passed and the worktree is clean. cargo fmt --check --all could not run because rustup attempted to write to a read-only toolchain directory; no files were modified. No spec-version bump is required for the release-449 base.

Findings

No findings.

Conclusion

The dependency and lockfile changes are consistent, narrowly scoped, and present no concrete domain-correctness issue. CI should provide the unavailable formatting and compilation validation.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant