Scope Salesforce agent guidance#937
Draft
adrian-rpf wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR scopes the Salesforce parent-sync race guard guidance into a job-local doc (app/jobs/salesforce/AGENTS.md) and replaces the root-level detailed directive with a pointer, keeping Salesforce sync operational guidance close to the relevant jobs.
Changes:
- Added
app/jobs/salesforce/AGENTS.mddescribing the parent-sync race guard, failure mode, and retry behavior for Salesforce sync jobs. - Updated root
AGENTS.mdto reference the job-specific Salesforce guidance instead of embedding the full directive.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/jobs/salesforce/AGENTS.md | Introduces scoped guidance for Salesforce sync jobs, including the parent-sync race guard and retry behavior. |
| AGENTS.md | Replaces the detailed parent-sync guidance with a pointer to the Salesforce jobs’ guidance doc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Salesforce Sync Jobs | ||
|
|
||
| ## Parent-Sync Race Guard | ||
| - Before saving a child record that uses a `__r__` external-ID lookup, call `ensure_parent_synced!(model, external_id_field, external_id, label)` on the `Salesforce::SalesforceSyncJob` base class. |
Test coverage92.17% line coverage reported by SimpleCov. |
adrian-rpf
marked this pull request as draft
July 23, 2026 17:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/jobs/salesforce/AGENTS.mdTests
git diff --check