Skip to content

chore(WebAPI): packages.lock.json corrections - #645

Merged
JasonLandbridge merged 37 commits into
devfrom
QuartzMigration
Aug 18, 2026
Merged

chore(WebAPI): packages.lock.json corrections#645
JasonLandbridge merged 37 commits into
devfrom
QuartzMigration

Conversation

@JasonLandbridge

@JasonLandbridge JasonLandbridge commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added reliable background job scheduling with clearer status, cancellation, and queue visibility.
    • Added a Queued job status.
    • Added automatic download pausing during application shutdown.
    • Added follow-up processing for completed downloads and library synchronization.
  • Bug Fixes
    • Improved Plex account access cleanup and cache updates.
    • Improved bulk cleanup of download and library data.
  • Improvements
    • Added application run identifiers to logs for easier troubleshooting.
    • Improved SQLite initialization and connection handling.

@JasonLandbridge
JasonLandbridge marked this pull request as ready for review August 18, 2026 12:00
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3e122916-83fd-4dcf-9d79-d9bf334c7d5b

📥 Commits

Reviewing files that changed from the base of the PR and between de95fd9 and 57bd6db.

📒 Files selected for processing (10)
  • src/AppHost/Boot.cs
  • src/Application/PlexLibraries/LibrarySync/Commands/CheckQueuedPlexLibraryToSync/CheckQueuedPlexLibraryToSyncCommand.cs
  • src/Application/PlexLibraries/_BackgroundJobs/LibrarySync/Commands/CancelLibrarySyncJobCommand.cs
  • src/Application/_Shared/Config/Autofac/QuartzModule.cs
  • tests/BaseTests/_Shared/Config/Autofac/TestModule.cs
  • tests/IntegrationTests/IntegrationTests/Application/PlexAccounts/Create/CreatePlexAccountEndpoint.IntegrationTests.cs
  • tests/IntegrationTests/IntegrationTests/Application/PlexAccounts/PlexSignIn/CreateAccount.IntegrationTests.cs
  • tests/IntegrationTests/IntegrationTests/FileSystem/MoveDownloadFile/MoveDownloadFileScheduler.IntegrationTests.cs
  • tests/UnitTests/Application.UnitTests/PlexDownloads/Execute/DownloadJobListener.UnitTests.cs
  • tests/UnitTests/Application.UnitTests/PlexLibraries/Comparison/State/ApplyOwnedTvShowComparisonStateCommand.UnitTests.cs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The application replaces TickerQ with Quartz for background-job scheduling. It adds Quartz startup, shutdown, SQLite persistence, payload handling, listeners, scheduler extensions, and job execution contracts. Background jobs report outcomes through Quartz contexts. Download and library-sync completion flows use listeners. Database cleanup uses batched deletion and revised SQLite initialization. Tests now mock Quartz APIs.

Estimated code review effort: 5 (Critical) | ~120 minutes

Merge Risk: 🟠 High · up to 57bd6

This PR changes background-job scheduling and cancellation behavior, but unresolved races and state-handling issues can leave cancelled work running, start duplicate work, stall queues, or misreport job outcomes. The current head is not ready to merge until these correctness risks are fixed or explicitly accepted.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes package lock corrections, but the changes primarily migrate background jobs from TickerQ to Quartz. Rename the pull request to clearly describe the Quartz background-job migration and related scheduler changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 7.34% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch QuartzMigration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@JasonLandbridge
JasonLandbridge merged commit 951118e into dev Aug 18, 2026
39 checks passed
@JasonLandbridge
JasonLandbridge deleted the QuartzMigration branch August 18, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant