Skip to content

Avoid unnecessary rehash in ChunkLevelManager and TicketDistanceLevelPropagator - #488

Open
InitAuther97 wants to merge 4 commits into
RelativityMC:dev/1.21.11from
InitAuther97:dev/1.21.11
Open

Avoid unnecessary rehash in ChunkLevelManager and TicketDistanceLevelPropagator#488
InitAuther97 wants to merge 4 commits into
RelativityMC:dev/1.21.11from
InitAuther97:dev/1.21.11

Conversation

@InitAuther97

Copy link
Copy Markdown

In ChunkLevelManager, ticket level updates are applied by removing the first entry from the update map. This introduces unnecessary shiftKey and rehash logics in our use case. We can avoid them all.

@PhantomG27249

PhantomG27249 commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Hello, could you provide some benchmarks and compatibility testing along with the pr? Along with hardware information and how you tested?

@InitAuther97

InitAuther97 commented Dec 12, 2025

Copy link
Copy Markdown
Author

Can confirm good compatibility with VMP, Lithium and ScalableLux by running chunky and walking around in the game with no error.
Since my device has only 10 cores and is incapable to make the main thread a bottleneck, I run spark to check the time cost here during a pregen task (which lasts 10min). There is a slight improvement in the time spent, as shown by the figures below (before, after).
图片
图片
profile.zip

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants