Prevent stale selection dismissal from replacing newer selections - #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A rapid third tap was consumed by two asynchronous paths. Blink upgraded it to a triple-click paragraph selection, while the selection toolbar treated the same gesture as an outside-tap dismissal. The native
ActionMode.finish()round trip then restored the dismissal's older collapsed caret over the newer paragraph selection, producing a visible paragraph-selection flash followed by collapse.Checking only after the native promise resolves is too late because
ActionMode.finish()can itself clear Chromium's selection. The fix therefore confirms ownership before entering native code, observes replacement selections while the bridge is in flight, and waits one additional animation frame after the bridge resolves before deciding whether the original caret is still safe to restore.Behavior
Verification
pnpm typecheckpnpm buildgit diff --checkCloses #205