Android: pin the rnp crypto backend to openssl for libretroshare too - #374
Closed
jolavillette wants to merge 1 commit into
Closed
Android: pin the rnp crypto backend to openssl for libretroshare too#374jolavillette wants to merge 1 commit into
jolavillette wants to merge 1 commit into
Conversation
build_librnp builds and installs rnp with -DCRYPTO_BACKEND=openssl, but libretroshare's own configure builds rnp a second time, inline, whenever ../supportlibs/librnp exists, which is the case when libretroshare is checked out inside the RetroShare super-project. That inline build gets rnp's default backend, botan, and dies with Could NOT find Botan (missing: BOTAN_LIBRARY BOTAN_INCLUDE_DIR) (Required is at least version "2.14.0") since the Android toolchain never builds botan. Pass the same backend as build_librnp. Harmless for standalone libretroshare checkouts, where the pre-built rnp from the sysroot is picked up instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by #375. Pinning the backend removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_librnpbuilds and installs rnp into the Android sysroot with-DCRYPTO_BACKEND=openssl, but libretroshare's own configure can build rnp a second time, inline:CMakeLists.txtusesadd_subdirectory()whenever../supportlibs/librnp/CMakeLists.txtexists, which is the case as soon as libretroshare is checked out inside the RetroShare super-project rather than standalone.That inline build gets rnp's default backend, botan, and configure dies with
since the Android toolchain never builds botan.
Passing the same backend
build_librnpuses fixes it. It is a no-op for standalone libretroshare checkouts, where../supportlibs/librnpdoes not exist and the pre-built rnp from the sysroot is picked up byfind_library()instead — which is why CI never saw this.Reported on IRC by defnax, who hit it building the AAR for rs-mobile from a super-project checkout.