feat: add holder-statement diff query - #824
Open
laxjovial wants to merge 2 commits into
Open
Conversation
Add holder_statement_diff(holder, period_a, period_b) to compute the delta of holdings and cumulative accrued amounts between two period IDs for a holder. Simplifies UI diff views and reduces client-side work by performing the subtraction on-chain. - New HolderStatementDelta struct with share_delta and claimed_delta - Rejects period_a > period_b with RevoraError::InvalidPeriodId - Rejects zero or out-of-range period IDs - Reuses compute_holder_payout_for_range for ledger aggregation - Includes comprehensive tests covering all edge cases Closes RevoraOrg#601
|
@laxjovial Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add holder_statement_diff(holder, period_a, period_b) to compute the delta of holdings and cumulative accrued amounts between two period IDs for a holder. Simplifies UI diff views and reduces client-side work by performing the subtraction on-chain.
Closes #601