Skip to content

Vdp2/rotation param b - #137

Open
seven-shades wants to merge 9 commits into
mainfrom
Vdp2/rotation-param-B
Open

Vdp2/rotation param b#137
seven-shades wants to merge 9 commits into
mainfrom
Vdp2/rotation-param-B

Conversation

@seven-shades

Copy link
Copy Markdown
Collaborator

-Added SRL Wrapper support for Rotation Parameter B in the RBG0 interface:
-Overloads for RBG0 loading functions allow loading 2 tilemaps where the secondary displays with Parameter B.
-Config for Parameter B can be made by specifying the enum RotationParameter::Secondary in the overloads.
-Added Functionality in the ScrollScreen Interface to Register any ScrollScreen to display the ASCII Scroll.
-Added Additional Sample demonstrating loading and switching fonts on the ASCII Scroll.
-Added Additional Sample demonstrating use of Both Rotation Parameters on RBG0.
-Additional changes to documentation and VDP2 samples.

seven-shades and others added 9 commits December 29, 2025 15:21
-ClearVRAM() : Added optional param to disable clearing palettes.
-LoadTilemap()/LoadBitmap(): Added optional param to disable auto loading palettes
- Added Rotation RB tilemap loading
-Added LoadTilemap overloads to streamline loading 2 tilemaps to RBG0
-Added Functions to adjust scale reduction limit in NBG0 and NBG1 interfaces
-Adjustments to VRAM automap allocation
-Minor documentation fixes
-Modified interface control of RBG0RB
-Added Rotation Parameter sample
-Bug Fixes

@ReyeMe ReyeMe left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are needed

// Initializes gouraud table work area
SRL::Scene3D::LightInitGouraudTable(0, vertWork, workTable, polygons);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless change, plese revert

int main()
{
SRL::Core::Initialize(HighColor(20,10,50));
Digital port0(0); // Initialize gamepad on port 0

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gamepad is never used

// Check that requested page indicies exist in this map:
if (!this->mapData || sourcePage >= this->numPages || destPage >= numPages)
{
{

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken formatting

if (info.PlaneSize == PL_SIZE_2x2) page_sz <<= 2;
else if (info.PlaneSize == PL_SIZE_2x1) page_sz <<= 1;

//if(info.MapByteSize)sz = info.MapByteSize;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

inline static CRAM::Palette TilePaletteB = CRAM::Palette();


void* SetCellAddress(void* address, int size, VDP2::RotationParameter param =VDP2::RotationParameter::Primary)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing documentation, remove multiple empty lines above, keep only single empty line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants