fix: honor explicit local-only routes in public client - #129
Merged
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The pre-1.0 exact-package HTTP smoke found that Python discarded a loopback route during discovery even though
IICP_PROXY_ALLOW_LOOPBACK_NODES=1allowed the same route in the pinned transport. TypeScript and Rust completed the same local-only path. This blocked the declared isolated/local-only qualification mode and prevented the packaged-client harness from comparing all three maintained clients.Validation
uv run --isolated --python 3.12 --locked --extra dev pytest -q tests/test_client.py tests/test_endpoint_security.pyuv run --isolated --python 3.11 --locked --extra dev ruff check src/iicp_client/client.py tests/test_client.pypython3 scripts/run_sdk_quality.pygate: Python 3.11/3.12/3.13, 1,243 tests plus subtests per runtime, Ruff, mypy baseline, 76.22% coverage, dependency audit, locked build and clean exact installThis source correction invalidates the previous non-authorizing Python artifact fragment. It does not publish a package, freeze a coordinated candidate or authorize a stable designation.