Skip to content

fix(graphql): select the reconciling-item fields on the fiscal calendar query #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfrench9 merged 1 commit into from
Aug 27, 2026
Merged

fix(graphql): select the reconciling-item fields on the fiscal calendar query #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions robosystems_client/graphql/generated/get_ledger_fiscal_calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ class GetLedgerFiscalCalendarFiscalCalendar(BaseModel):
stranded_obligation_sample: list[
"GetLedgerFiscalCalendarFiscalCalendarStrandedObligationSample"
] = Field(alias="strandedObligationSample")
reconciling_item_count: int = Field(alias="reconcilingItemCount")
reconciling_item_sample: list[str] = Field(alias="reconcilingItemSample")
sync_stale_days: Optional[int] = Field(alias="syncStaleDays")
last_close_at: Optional[str] = Field(alias="lastCloseAt")
initialized_at: Optional[str] = Field(alias="initializedAt")
Expand Down
2 changes: 2 additions & 0 deletions robosystems_client/graphql/generated/operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,8 @@
scheduleName
period
}
reconcilingItemCount
reconcilingItemSample
syncStaleDays
lastCloseAt
initializedAt
Expand Down
1 change: 1 addition & 0 deletions robosystems_client/graphql/operations/ledger/GetLedgerFiscalCalendar.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ query GetLedgerFiscalCalendar {
earliestPendingPeriod
strandedObligationCount
strandedObligationSample { eventId scheduleId scheduleName period }
reconcilingItemCount reconcilingItemSample
syncStaleDays
lastCloseAt initializedAt lastSyncAt
periods { name startDate endDate status closedAt }
Expand Down
8 changes: 8 additions & 0 deletions tests/test_ledger_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ def test_get_fiscal_calendar(self, mock_execute, mock_config, graph_id):
"earliestPendingPeriod": None,
"strandedObligationCount": 0,
"strandedObligationSample": [],
"reconcilingItemCount": 0,
"reconcilingItemSample": [],
"syncStaleDays": None,
"lastCloseAt": None,
"initializedAt": "2026-01-01T00:00:00Z",
Expand All @@ -272,6 +274,8 @@ def test_get_fiscal_calendar(self, mock_execute, mock_config, graph_id):
assert cal.closeable_now is True
assert cal.fiscal_year_start_month == 1
assert cal.stranded_obligation_count == 0
assert cal.reconciling_item_count == 0
assert cal.reconciling_item_sample == []

@patch("robosystems_client.graphql.client.GraphQLClient.execute")
def test_get_fiscal_calendar_names_blocking_obligations(
Expand Down Expand Up @@ -304,6 +308,8 @@ def test_get_fiscal_calendar_names_blocking_obligations(
"period": "2026-03",
}
],
"reconcilingItemCount": 1,
"reconcilingItemSample": ["ri_bank_fee_2026-03"],
"syncStaleDays": None,
"lastCloseAt": None,
"initializedAt": "2026-01-01T00:00:00Z",
Expand All @@ -319,6 +325,8 @@ def test_get_fiscal_calendar_names_blocking_obligations(
assert cal.stranded_obligation_count == 2
assert cal.stranded_obligation_sample[0].schedule_name == "Prepaid Insurance"
assert cal.stranded_obligation_sample[0].period == "2026-03"
assert cal.reconciling_item_count == 1
assert cal.reconciling_item_sample == ["ri_bank_fee_2026-03"]


# ── Writes (Operation envelope) ────────────────────────────────────────
Expand Down