refactor(clients): drop the POC operator methods that never had an operator behind them - #199
Merged
Merged
Conversation
…erator behind them OperatorClient.analyze_financials / research / rag (and the module-level analyze_financials convenience) sent operator_type financial / research / rag. None was ever registered on the API — only cypher (now analyst) and mapping exist — so every call 404'd. No consumer in the three apps, core, the integration template, or the demo integration. Removal changes symbol resolution only: the SDK contract's dead-surface carve-out, riding a client minor. query() (auto-select) and execute_operator(graph_id, type, …) are the surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes three facade methods that never had an operator behind them.
OperatorClient.analyze_financials(),.research(), and.rag()(plus the module-levelanalyze_financialsconvenience) sentoperator_type=financial/research/rag— none of which has ever been registered on the API (onlycypher, nowanalyst, andmappingexist), so every call 404'd. They were early-POC placeholders that survived into the facade.Changes
robosystems_client/clients/operator_client.py— removedanalyze_financials,research,rag.query()(auto-select) andexecute_operator(graph_id, operator_type, …)remain the surface; nothing else in the class changed.robosystems_client/clients/__init__.py— removed the module-levelanalyze_financialsconvenience (it was never in__all__).tests/test_operator_client.py— removed the three tests that pinned the dead methods. The genericexecute_operatortests keep their placeholder type strings; they exercise the pass-through, not a real operator.Sync and async: the facade is sync-only; no async counterpart existed.
Compatibility
By the template's letter this is BREAKING (removed exports). It ships under the SDK contract's dead-surface carve-out — a client minor, no deprecation cycle — because all three conditions hold: (1) the methods never functioned in any shipped configuration (the operator types were never registered; every call returned 404); (2) no consumer exists — none of the three apps,
robosystems-core,robosystems-integration-template, orrobosystems-demo-integrationreferences them; (3) removal changes symbol resolution only — no working call's behavior changes. A consumer that somehow called them has a 404 today and anAttributeErrorafter; the fix in both cases isexecute_operator(graph_id, "analyst", …)orquery().Testing
just test-all— pytest 523 passed / 17 skipped, ruff check + format clean, basedpyright 0 errors. Pre-commit hook ran the same set.