Skip to content

[FIX] Updated names in thread messages. - #20634

Open
Darshilp326 wants to merge 6 commits into
RocketChat:developfrom
Darshilp326:Update-name
Open

[FIX] Updated names in thread messages.#20634
Darshilp326 wants to merge 6 commits into
RocketChat:developfrom
Darshilp326:Update-name

Conversation

@Darshilp326

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Thread messages would now include updated names.

name-update-pr.mp4

Issue(s)

Closes #20633

Steps to test or reproduce

Further comments

@Darshilp326

Copy link
Copy Markdown
Contributor Author

Actually, none of the messages contains the updated name in the database. So after this PR, it would fix that issue also.

@jsalatiel

Copy link
Copy Markdown

Would this fix #18270 by any chance?

@ggazzo
ggazzo requested review from a team and sampaiodiego February 8, 2021 12:57
@KevLehman

Copy link
Copy Markdown
Member

Hey @Darshilp326 ! Thanks again for contributing. Even when the PR solves the issue, I don't think it's the best way of doing it. Currently, we're not storing the name of the user in the database, just the username. This facilitates updates and reduces the amount of data that we need to care about when a user changes his profile information.

I was taking a look at the getThreadMessages file, which controls the data we return to the client. In that place, we're missing a normalization step, which is the one in charge of adding the name of the user to each payload, as you can see here

I can help you with the changes if you want. Thanks again!

Comment thread app/threads/server/methods/getThreadMessages.js Outdated
KevLehman
KevLehman previously approved these changes Feb 19, 2021
@ggazzo ggazzo added this to the 3.12.0 milestone Feb 20, 2021

@rodrigok rodrigok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing normalization on other threads methods and rest apis

@Darshilp326

Copy link
Copy Markdown
Contributor Author

@rodrigok Onto it!

@Darshilp326

Copy link
Copy Markdown
Contributor Author

@rodrigok Hello! Can you tell which API/methods are you exactly referring to?

@Darshilp326

Copy link
Copy Markdown
Contributor Author

@KevLehman @rodrigok Sorry sir, I missed this PR. Can you please review it?

@CLAassistant

CLAassistant commented Dec 17, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Messages doesn't have updated names in threads.

9 participants