fix: keep unique items visible in analysis - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact
uv.lockwith project version 0.3.1For the supplied
data copy.xlsm, the verified values are 149 cheapest-everywhere items and 2415 unique items.Root cause
The unique-items metric existed in cells G5:H5, but the wide dashboard pushed it outside the initial viewport on narrower Excel windows. It therefore appeared to be missing even though its value was present.
Validation
.venv/bin/ruff check ..venv/bin/mypyUV_CACHE_DIR=/tmp/pharmparser-uv-cache uv lock --checkUV_CACHE_DIR=/tmp/pharmparser-uv-cache uv run pytest --ignore=tests/integration/test_gui.py— 327 passedThe remaining GUI tests require Xvfb and are covered by CI.