Complete the Classic Era 1.15.9 C_AddOns fix (stacked on #320) - #321
Open
Pimptasty wants to merge 4 commits into
Open
Complete the Classic Era 1.15.9 C_AddOns fix (stacked on #320)#321Pimptasty wants to merge 4 commits into
Pimptasty wants to merge 4 commits into
Conversation
Attempting fix for Classic 1.15.9, which appears to have adopted more of Retail's namespaced AddOn API. GetAddOnMetadata is no longer available as a global, so this line explodes during addon initialization. This is exactly the same class of breakage that happened on Retail in 11.0 when Blizzard moved APIs into C_AddOns
Attempting fix for Classic 1.15.9, which appears to have adopted more of Retail's namespaced AddOn API. GetAddOnMetadata is no longer available as a global, so this line explodes during addon initialization. This is exactly the same class of breakage that happened on Retail in 11.0 when Blizzard moved APIs into C_AddOns
Rottenbeer#320 aliases GetAddOnMetadata in ItemRack.lua and the AddOn API in ItemRackButtons.lua, which stops the load-time crash. Three call sites are still left resolving to the removed globals, because Lua locals do not cross file boundaries: - ItemRack.lua:1946-1947 EnableAddOn / LoadAddOn in ItemRack.ToggleOptions - ItemRackEvents.lua:280 LoadAddOn in ItemRack.ToggleEvents Both paths load the LoD ItemRackOptions addon, so on 1.15.9 opening the options panel or toggling events still errors with "attempt to call a nil value" even with Rottenbeer#320 applied. Adds the matching aliases using the same guarded pattern as Rottenbeer#320, so TBC/Wrath/Cata, which still only have the globals, are unaffected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Classic Era is on 1.15.9 (build 68940, interface 11509); the Vanilla directive still declared 11505, so the addon shows as out of date. Only the Interface-Vanilla line is touched - TBC, Wrath and Cata keep their current values. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge #320 first — this PR is stacked on top of it
This branch is built directly on @umuppetu's #320 (
ffbb27a), not onmaster. Until #320 is merged, the diff shown here includes their two commits as well as mine. Once #320 lands, this PR's diff reduces to just the two commits below and applies cleanly.Merge order: #320, then this. If you'd rather have it as a single PR, say so and I'll rebase onto
masterand fold #320's changes in with credit.What #320 already fixes
Classic Era 1.15.9 completed the
C_AddOnsmigration Retail did in 11.0 and removed the AddOn API globals.ItemRack.lua's first executable statement calledGetAddOnMetadata, so the file aborted at load and nothing initialized — the reported symptom in #319. #320 correctly guards that, plus theItemRackButtons.luauses.What this adds
Lua locals don't cross file boundaries, and #320's
ItemRack.luaalias only coversGetAddOnMetadata. Three call sites still resolve to the removed globals:ItemRack/ItemRack.luaEnableAddOnItemRack.ToggleOptionsItemRack/ItemRack.luaLoadAddOnItemRack.ToggleOptionsItemRack/ItemRackEvents.luaLoadAddOnItemRack.ToggleEventsBoth paths load the LoD
ItemRackOptions, so with #320 alone the addon loads but opening the options panel or toggling events still throwsattempt to call a nil value.This uses the same guarded pattern as #320, so TBC/Wrath/Cata — which still only have the globals — resolve to them unchanged:
I checked
ItemRackOptions/separately; it has no affected call sites.Second commit:
Interface-VanillabumpClassic Era is on 1.15.9 / interface 11509, while both
.tocfiles still declare## Interface-Vanilla: 11505, so the addon flags as out of date. Only the Vanilla line is changed in each; TBC/Wrath/Cata values are untouched. Drop this commit if you'd rather handle toc bumps in your own release commits.Verification
luac -p.C_AddOns.GetAddOnMetadata,.LoadAddOnand.EnableAddOnall exist and are in active use by other addons on that client.Refs #319. Does not touch the binding/macro changes proposed in #318.
🤖 Generated with Claude Code