Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Section entry derives presentation from the destination section's own state. When the destination has the same background music, persistent sound effect channel or video background as before the change, that media keeps its render identity and plays on without restarting; when the destination omits or replaces it, it stops or switches. This behaviour was not covered by tests, and the docs still described
context.bgmas the current background music.Tests:
spec/RouteEngine.sectionPresentationContinuity.test.jscovers identical, omitted and different media through normal transitions,resetStoryAtSection, choice transitions and save/load; a visual test case (vt/specs/robustness/section-media-continuity.yaml, added to CI) exercises a choice-driven transition with a video background.Docs:
context.bgmis described as a legacy compatibility field; active music is derived from the current section's presentation state.The full suite (2,172 tests), lint, the test-marker check and the visual capture pass.