Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spritesheet clips address frames by index into the atlas's key order, which JavaScript enumerates with array-index-like keys first: with authored frame order
["10", "2", "1"], clip indexes[0, 1]resolve to["1", "2"]. The schema also rejects frame names.Reproduce: an atlas with numeric-looking frame keys and a clip addressing them by index (regression tests and a visual test).
Fix: clip frames may be indexes or names, so clips can address frames without relying on key enumeration order.
Tests: schema, renderer and visual coverage (no visual mismatches); the full suite (2,164 tests) and lint pass.