Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering one authored layout in two places at once (as the main layout and as an overlay, or as a background and as the dialogue layout) produces elements with duplicate IDs.
Reproduce: render the same layout as the main layout and as an overlay (regression tests).
Fix: IDs are preserved for a single instance; when authored elements recur across rendered instances, each gets a stable unique ID.
Tests: main-plus-overlay and background-plus-dialogue cases, including stability across renders and immutability of the source; the full suite (2,164 tests) and lint pass.